Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite and refactor format_args!() builtin macro. #100996

Merged
merged 14 commits into from
Sep 28, 2022
Merged

Rewrite and refactor format_args!() builtin macro. #100996

merged 14 commits into from
Sep 28, 2022

Commits on Sep 27, 2022

  1. Rewrite and refactor format_args!() builtin macro.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    9bec0de View commit details
    Browse the repository at this point in the history

  2. Update tests.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    3ffcb65 View commit details
    Browse the repository at this point in the history

  3. Move FormatArgs structure to its own module.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8efc383 View commit details
    Browse the repository at this point in the history

  4. Fix typo.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    0007492 View commit details
    Browse the repository at this point in the history

  5. Prefer new_v1_formatted instead of new_v1 with duplicates.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ae238ef View commit details
    Browse the repository at this point in the history

  6. Tweak comments.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    e65c96e View commit details
    Browse the repository at this point in the history

  7. Use if let chain.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    df7fd11 View commit details
    Browse the repository at this point in the history

  8. Move enum definition closer to its usage.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    15754f5 View commit details
    Browse the repository at this point in the history

  9. Flatten if-let and match into one.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    8d9a588 View commit details
    Browse the repository at this point in the history

  10. Add clarifying comments.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    c1c6e3a View commit details
    Browse the repository at this point in the history

  11. Update test.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1406563 View commit details
    Browse the repository at this point in the history

  12. Turn format arguments Vec into its own struct. 

    With efficient lookup through a hash map.
    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    cf53fef View commit details
    Browse the repository at this point in the history

  13. Update doc comments.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ba7bf1d View commit details
    Browse the repository at this point in the history

  14. Remove confusing drop.

    @m-ou-se
    m-ou-se committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    20bb600 View commit details
    Browse the repository at this point in the history