Make call suggestions more general and more accurate #101100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Aug 27, 2022
| @@ -1,16 +1,28 @@ | |||
| // This test case checks the behavior of typeck::check::method::suggest::is_fn on Ty::Error. | |||
|
|
|||
| struct Foo; | |||
There was a problem hiding this comment.
Had to fix this test since we no longer say "perhaps you wish to call it" on a method that doesn't exist.
| @@ -6,7 +6,7 @@ enum Foo{ | |||
| Tup() | |||
| } | |||
| impl Foo { | |||
| fn foo() { } | |||
| fn foo(&self) { } | |||
There was a problem hiding this comment.
Had to fix this test because the suggestion makes no sense without it
compiler-errors
force-pushed
the
generalize-call-suggestions
branch
from
f0a0a65
to
460ebc4
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
generalize-call-suggestions
branch
from
460ebc4
to
cef0482
Compare
compiler-errors
force-pushed
the
generalize-call-suggestions
branch
from
8b711fd
to
1256530
Compare
compiler-errors
commented
Aug 28, 2022
| self.flags | ||
| .treat_err_as_bug | ||
| .map_or(false, |c| self.err_count() + self.lint_err_count >= c.get()) | ||
| self.flags.treat_err_as_bug.map_or(false, |c| { |
There was a problem hiding this comment.
Well, I didn't mean to include this, but this is a fix to -Ztreat-err-as-bug which doesn't count delayed bugs correctly. I can remove it and put it into another PR if needed.
--
detailed explanation: If we emit an error A, delay a bug B, then emit error C. Then:
- running
-Ztreat-err-as-bug=1will make it ICE on A. - running
-Ztreat-err-as-bug=2will make it ICE on B. - running
-Ztreat-err-as-bug=3will skip over B and will make rust skip over C.
So there's literally no value N such that -Ztreat-err-as-bug=N will properly work to catch C. We add the delayed good path and span bugs into the count here so this works properly now.
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 31, 2022
…ggestions, r=petrochenkov Make call suggestions more general and more accurate Cleans up some suggestions that have to do with adding `()` to make typeck happy. 1. Drive-by rename of `expr_t` to `base_ty` since it's the type of the `base_expr` 1. Autoderef until we get to a callable type in `suggest_fn_call`. 1. Don't erroneously suggest calling constructor when a method/field does not exist on it. 1. Suggest calling a method receiver if its function output has a method (e.g. `fn.method()` => `fn().method()`) 1. Extend call suggestions to type parameters, fn pointers, trait objects where possible 1. Suggest calling in operators too (fixes rust-lang#101054) 1. Use `/* {ty} */` as argument placeholder instead of just `_`, which is confusing and makes suggestions look less like `if let` syntax.
This was referenced Aug 31, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#100970 (Allow deriving multipart suggestions) - rust-lang#100984 (Reinstate preloading of some dll imports) - rust-lang#101011 (Use getentropy when possible on all Apple platforms) - rust-lang#101025 (Add tier-3 support for powerpc64 and riscv64 openbsd) - rust-lang#101049 (Remove span fatal from ast lowering) - rust-lang#101100 (Make call suggestions more general and more accurate) - rust-lang#101171 (Fix UB from misalignment and provenance widening in `std::sys::windows`) - rust-lang#101185 (Tweak `WellFormedLoc`s a bit) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up some suggestions that have to do with adding
()to make typeck happy.expr_ttobase_tysince it's the type of thebase_exprsuggest_fn_call.fn.method()=>fn().method())size_ofwhen it is missing parens in a comparison #101054)/* {ty} */as argument placeholder instead of just_, which is confusing and makes suggestions look less likeif letsyntax.