Fix the example code and doctest for Formatter::sign_plus

[mousetail]

The provided example to the sign_plus method on fmt was broken, it displays the - sign twice for negative numbers.

This pull request should fix the issue by .abs() ing the number so that the negative sign appears only once. It is just one possible solution to the issue, not sure if it's the best. However, this one will behave as expected when combined with fill and alignment operators.

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information.

[fee1-dead]

Could you add a doctest below, near the assert_eqs?

assert_eq!(&format!("{:+}", Foo(23)), "Foo(+23)");
assert_eq!(&format!("{}", Foo(23)), "Foo(23)");
// ADD Foo(-23) HERE

[mousetail]

Could you add a doctest below, near the assert_eqs?

assert_eq!(&format!("{:+}", Foo(23)), "Foo(+23)");
assert_eq!(&format!("{}", Foo(23)), "Foo(23)");
// ADD Foo(-23) HERE

Fixed

[thomcc]

Looks good, but do you mind squashing your commits into one and giving that one a slightly more specific message (Maybe something along the lines of "Fix doctest for Formatter::sign_plus")?

Thanks!

[mousetail]

Looks good, but do you mind squashing your commits into one and giving that one a slightly more specific message (Maybe something along the lines of "Fix doctest for Formatter::sign_plus")?

Thanks!

I changed the name. Not sure how to squash commits from the web UI though. Won't the merge process do this automatically?

[thomcc]

@bors r+ rollup

[bors]

📌 Commit 5fbe485 has been approved by thomcc

It is now in the queue for this repository.