Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of io::ErrorKind::Other in std #102036

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

Patiga
Copy link
Contributor

@Patiga Patiga commented Sep 20, 2022

The documentation states that this ErrorKind is not used by the standard library. Instead, io::ErrorKind::Uncategorized should be used.

The two instances are in the unstable API linux_pidfd.

The documentation states that this `ErrorKind` is not used by the
standard library. Instead, `io::ErrorKind::Uncategorized` should be
used.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2022
@Patiga
Copy link
Contributor Author

Patiga commented Sep 20, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 20, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Since this is an unstable feature seems OK to change here, particularly to unspecified.

Also filed #102122 to try to chase down other cases.

@bors
Copy link
Contributor

bors commented Sep 22, 2022

📌 Commit 04c1087 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 22, 2022
…se-in-std, r=Mark-Simulacrum

Remove use of `io::ErrorKind::Other` in std

The documentation states that this `ErrorKind` is not used by the standard library. Instead, `io::ErrorKind::Uncategorized` should be used.

The two instances are in the unstable API [linux_pidfd](rust-lang#82971).
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101598 (Update rustc's information on Android's sanitizers)
 - rust-lang#102036 (Remove use of `io::ErrorKind::Other` in std)
 - rust-lang#102037 (Make cycle errors recoverable)
 - rust-lang#102069 (Skip `Equate` relation in `handle_opaque_type`)
 - rust-lang#102076 (rustc_transmute: fix big-endian discriminants)
 - rust-lang#102107 (Add missing space between notable trait tooltip and where clause)
 - rust-lang#102119 (Fix a typo “pararmeter” in error message)
 - rust-lang#102131 (Added which number is computed in compute_float.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Sep 22, 2022

☔ The latest upstream changes (presumably #102139) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 22, 2022
@bors bors merged commit c99a603 into rust-lang:master Sep 22, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 22, 2022
@Patiga Patiga deleted the remove-io-errorkind-other-use-in-std branch September 24, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants