Added more const_closure functionality #102276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
added
the
S-waiting-on-review
onestacked
force-pushed
the
const_closure_ext
branch
2 times, most recently
from
932c33b
to
d4e5e0b
Compare
fee1-dead
reviewed
Sep 26, 2022
fee1-dead
approved these changes
Sep 30, 2022
onestacked
force-pushed
the
const_closure_ext
branch
from
b9695f4
to
fa93a1a
Compare
|
@bors r+ rollup |
|
📌 Commit fa93a1a476d53dbd93c0eef12a330a60c1915f38 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
@bors r- |
bors
added
S-waiting-on-author
fee1-dead
reviewed
Sep 30, 2022
library/core/src/const_closure.rs
Outdated
Comment on lines
64
to
73
| { | ||
| extern "rust-call" fn call_mut(&mut self, args: ClosureArguments) -> Self::Output { | ||
| #[allow(non_snake_case)] | ||
| let ($($var),*) = &mut self.data; | ||
| (self.func)(($($var),*), args) | ||
| } | ||
| } | ||
|
|
||
| impl<'a, CapturedData: ?Sized, ClosureArguments, Function, ClosureReturnValue> const | ||
| FnMut<ClosureArguments> for ConstFnMutClosure<'a, CapturedData, Function> | ||
| where | ||
| Function: ~const Fn(&mut CapturedData, ClosureArguments) -> ClosureReturnValue, | ||
| { | ||
| extern "rust-call" fn call_mut(&mut self, args: ClosureArguments) -> Self::Output { | ||
| (self.func)(self.data, args) | ||
| } | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Sorry for the nits, but this isn't formatted properly. The last brace should have no spaces before them, and all of these should have four spaces.
r=me once you are done
|
@bors delegate+ After you are done, mention bors and |
|
✌️ @chriss0612 can now approve this pull request |
onestacked
force-pushed
the
const_closure_ext
branch
from
fa93a1a
to
10739d4
Compare
|
@bors r=fee1-dead |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#102276 (Added more const_closure functionality) - rust-lang#102382 (Manually order `DefId` on 64-bit big-endian) - rust-lang#102421 (remove the unused :: between trait and type to give user correct diag…) - rust-lang#102495 (Reinstate `hir-stats.rs` test for stage 1.) - rust-lang#102505 (rustdoc: remove no-op CSS `h3.variant, .sub-variant h4 { border-bottom: none }`) - rust-lang#102506 (Specify `DynKind::Dyn`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables ConstFnMutClosure to use a tuple of mutable references instead of just a mutable reference to a tuple.
Removes the new function, since it would barely be usable with this new code.
r? @fee1-dead