Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename rustc_typeck to rustc_hir_analysis #102306

Merged
merged 1 commit into from
Sep 27, 2022
Merged

rename rustc_typeck to rustc_hir_analysis #102306

merged 1 commit into from
Sep 27, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 26, 2022

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 26, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2022
@bors
Copy link
Contributor

bors commented Sep 26, 2022

☔ The latest upstream changes (presumably #102224) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr lcnr force-pushed the rustc_hir_analysis branch 2 times, most recently from 30766a0 to 668cc19 Compare September 26, 2022 15:32
@bors
Copy link
Contributor

bors commented Sep 26, 2022

☔ The latest upstream changes (presumably #102051) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors
Copy link
Member

This just renames the whole crate? If so, then I guess that's a fine first step. r=me

@bors p=5 rollup=never since it's bitrotty

@lcnr
Copy link
Contributor Author

lcnr commented Sep 27, 2022

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Sep 27, 2022

📌 Commit 1fc86a6 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2022
@lcnr lcnr changed the title rustc_typeck to rustc_hir_analysis rename rustc_typeck to rustc_hir_analysis Sep 27, 2022
@bors
Copy link
Contributor

bors commented Sep 27, 2022

⌛ Testing commit 1fc86a6 with merge 57ee5cf...

@bors
Copy link
Contributor

bors commented Sep 27, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 57ee5cf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2022
@bors bors merged commit 57ee5cf into rust-lang:master Sep 27, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 27, 2022
@bors bors mentioned this pull request Sep 27, 2022
Closed
@lcnr lcnr deleted the rustc_hir_analysis branch September 27, 2022 13:22
This was referenced Sep 27, 2022
Merged
Merged
Merged
Closed
Merged
This was referenced Sep 27, 2022
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (57ee5cf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)		 -2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)		 -4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.2% [-3.2%, -3.2%] 1
Improvements ✅
(secondary)		 -2.6% [-3.1%, -2.1%] 2
All ❌✅ (primary) -3.2% [-3.2%, -3.2%] 1

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@davidtwco davidtwco mentioned this pull request Sep 28, 2022
Merged
davidtwco added a commit to davidtwco/rust that referenced this pull request Sep 28, 2022
@davidtwco
errors: rename typeck.ftl to hir_analysis.ftl
715d61d 
In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the
diagnostic resources were not renamed - which is what this commit
changes.

Signed-off-by: David Wood <david.wood@huawei.com>
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#102395 - davidtwco:translation-rename-typec…
51743a2 
…k, r=estebank

errors: rename `typeck.ftl` to `hir_analysis.ftl`

In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the diagnostic resources were not renamed - which is what this pull request changes.
davidtwco added a commit to davidtwco/rust that referenced this pull request Oct 3, 2022
@davidtwco
errors: rename typeck.ftl to hir_analysis.ftl
c4418e1 
In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the
diagnostic resources were not renamed - which is what this commit
changes.

Signed-off-by: David Wood <david.wood@huawei.com>
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 4, 2022
@bors
Auto merge of rust-lang#102395 - davidtwco:translation-rename-typeck,…
d9f8b4b 
… r=compiler-errors

errors: rename `typeck.ftl` to `hir_analysis.ftl`

In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the diagnostic resources were not renamed - which is what this pull request changes.
@mejrs mejrs mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo left review comments

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lcnr @rustbot @bors @compiler-errors @rust-timer @Alexendoo @rust-highfive