-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #102630
Rollup of 8 pull requests #102630
Commits on Jun 18, 2022
-
Document the conditional existence of
alloc::sync
andalloc::task
.The wording is copied from `std::sync::atomic::AtomicPtr`, with additional advice on how to `#[cfg]` for it.
Configuration menu - View commit details
-
Copy full SHA for 5dcc418 - Browse repository at this point
Copy the full SHA 5dcc418View commit details
Commits on Jul 13, 2022
-
docs: be less harsh in wording for Vec::from_raw_parts
In particular, be clear that it is sound to specify memory not originating from a previous `Vec` allocation. That is already suggested in other parts of the documentation about zero-alloc conversions to Box<[T]>. Incorporate a constraint from `slice::from_raw_parts` that was missing but needs to be fulfilled, since a `Vec` can be converted into a slice.
Configuration menu - View commit details
-
Copy full SHA for 9cd66be - Browse repository at this point
Copy the full SHA 9cd66beView commit details
Commits on Jul 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c9ec7aa - Browse repository at this point
Copy the full SHA c9ec7aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 050115c - Browse repository at this point
Copy the full SHA 050115cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d35ab3 - Browse repository at this point
Copy the full SHA 8d35ab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a85ee3e - Browse repository at this point
Copy the full SHA a85ee3eView commit details
Commits on Jul 19, 2022
-
docs: Improve AsRef / AsMut docs on blanket impls
- Explicitly mention that `AsRef` and `AsMut` do not auto-dereference generally for all dereferencable types (but only if inner type is a shared and/or mutable reference) - Give advice to not use `AsRef` or `AsMut` for the sole purpose of dereferencing - Suggest providing a transitive `AsRef` or `AsMut` implementation for types which implement `Deref` - Add new section "Reflexivity" in documentation comments for `AsRef` and `AsMut` - Provide better example for `AsMut` - Added heading "Relation to `Borrow`" in `AsRef`'s docs to improve structure Issue rust-lang#45742 and a corresponding FIXME in the libcore suggest that `AsRef` and `AsMut` should provide a blanket implementation over `Deref`. As that is difficult to realize at the moment, this commit updates the documentation to better describe the status-quo and to give advice on how to use `AsRef` and `AsMut`.
Configuration menu - View commit details
-
Copy full SHA for 551d921 - Browse repository at this point
Copy the full SHA 551d921View commit details -
fixup! docs: Improve AsRef / AsMut docs on blanket impls
Fixed examples in sections "Generic Implementations" of `AsRef`'s and `AsMut`'s doc comments, which failed tests.
Configuration menu - View commit details
-
Copy full SHA for 9f68e3e - Browse repository at this point
Copy the full SHA 9f68e3eView commit details -
fixup! docs: Improve AsRef / AsMut docs on blanket impls
Better conform to Rust API Documentation Conventions
Configuration menu - View commit details
-
Copy full SHA for e4a259b - Browse repository at this point
Copy the full SHA e4a259bView commit details
Commits on Jul 21, 2022
-
fixup! docs: Improve AsRef / AsMut docs on blanket impls
Changed wording in sections on "Reflexivity": replaced "that is there is" with "i.e. there would be" and removed comma before "with" Reason: "there is" somewhat contradicted the "would be" hypothetical. A slightly redundant wording has now been chosen for better clarity. The comma seemed to be superfluous.
Configuration menu - View commit details
-
Copy full SHA for e6b761b - Browse repository at this point
Copy the full SHA e6b761bView commit details
Commits on Aug 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 698a3c6 - Browse repository at this point
Copy the full SHA 698a3c6View commit details
Commits on Sep 5, 2022
-
Fix
#[derive(Default)]
on a generic#[default]
enum adding unnece……ssary `Default` bounds
Configuration menu - View commit details
-
Copy full SHA for cb86c38 - Browse repository at this point
Copy the full SHA cb86c38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 975e72f - Browse repository at this point
Copy the full SHA 975e72fView commit details
Commits on Sep 15, 2022
-
Future-proof against loose bounds if default variant is non-exhaustive.
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3d4980b - Browse repository at this point
Copy the full SHA 3d4980bView commit details
Commits on Sep 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 591c1f2 - Browse repository at this point
Copy the full SHA 591c1f2View commit details
Commits on Oct 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5fd0240 - Browse repository at this point
Copy the full SHA 5fd0240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90b5784 - Browse repository at this point
Copy the full SHA 90b5784View commit details -
Configuration menu - View commit details
-
Copy full SHA for e962dd9 - Browse repository at this point
Copy the full SHA e962dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a6f61c - Browse repository at this point
Copy the full SHA 2a6f61cView commit details
Commits on Oct 3, 2022
-
Add diagnostic struct for const eval error in
rustc_middle
Co-authored-by: Michael Goulet <michael@errs.io>
Configuration menu - View commit details
-
Copy full SHA for b9c0467 - Browse repository at this point
Copy the full SHA b9c0467View commit details -
Rollup merge of rust-lang#98061 - WaffleLapkin:own_the_option, r=josh…
…triplett Add `Option::owned` This PR adds the following public library APIs: ```rust impl<T: ?Sized> Option<&T> { pub const fn owned(self) -> Option<T::Owned> where T: ~const ToOwned; } impl<T: ?Sized> Option<&mut T> { pub fn owned(self) -> Option<T::Owned> where T: ~const ToOwned; } ``` `Option::owned` is similar to `Option::cloned` and `Option::copied`, but uses the `ToOwned` trait. --- I thought that would be easier, but since `ToOwned` is defined in the alloc crate this becomes incoherent :')
Configuration menu - View commit details
-
Copy full SHA for a01e4df - Browse repository at this point
Copy the full SHA a01e4dfView commit details -
Rollup merge of rust-lang#98218 - kpreid:nostdarc, r=joshtriplett
Document the conditional existence of `alloc::sync` and `alloc::task`. `alloc` declares ```rust #[cfg(target_has_atomic = "ptr")] pub mod sync; ``` but there is no public documentation of this condition. This PR fixes that, so that users of `alloc` can understand how to make their code compile everywhere `alloc` does, if they are writing a library with impls for `Arc`. The wording is copied from `std::sync::atomic::AtomicPtr`, with additional advice on how to `#[cfg]` for it. I feel quite uncertain about whether the paragraph I added to `Arc`'s documentation should actually be there, as it is a distraction for anyone using `std`. On the other hand, maybe more reminders that no_std exists would benefit the ecosystem. Note: `target_has_atomic` is [stabilized](rust-lang#32976) but [not yet documented in the reference](rust-lang/reference#1171).
Configuration menu - View commit details
-
Copy full SHA for 9efb044 - Browse repository at this point
Copy the full SHA 9efb044View commit details -
Rollup merge of rust-lang#99216 - duarten:master, r=joshtriplett
docs: be less harsh in wording for Vec::from_raw_parts In particular, be clear that it is sound to specify memory not originating from a previous `Vec` allocation. That is already suggested in other parts of the documentation about zero-alloc conversions to Box<[T]>. Incorporate a constraint from `slice::from_raw_parts` that was missing but needs to be fulfilled, since a `Vec` can be converted into a slice. Fixes rust-lang#98780.
Configuration menu - View commit details
-
Copy full SHA for a19b369 - Browse repository at this point
Copy the full SHA a19b369View commit details -
Rollup merge of rust-lang#99460 - JanBeh:PR_asref_asmut_docs, r=josht…
…riplett docs: Improve AsRef / AsMut docs on blanket impls There are several issues with the current state of `AsRef` and `AsMut` as [discussed here on IRLO](https://internals.rust-lang.org/t/semantics-of-asref/17016). See also rust-lang#39397, rust-lang#45742, rust-lang#73390, rust-lang#98905, and the FIXMEs [here](https://github.com/rust-lang/rust/blob/1.62.0/library/core/src/convert/mod.rs#L509-L515) and [here](https://github.com/rust-lang/rust/blob/1.62.0/library/core/src/convert/mod.rs#L530-L536). These issues are difficult to fix. This PR aims to update the documentation to better reflect the status-quo and to give advice on how `AsRef` and `AsMut` should be used. In particular: - Explicitly mention that `AsRef` and `AsMut` do not auto-dereference generally for all dereferencable types (but only if inner type is a shared and/or mutable reference) - Give advice to not use `AsRef` or `AsMut` for the sole purpose of dereferencing - Suggest providing a transitive `AsRef` or `AsMut` implementation for types which implement `Deref` - Add new section "Reflexivity" in documentation comments for `AsRef` and `AsMut` - Provide better example for `AsMut` - Added heading "Relation to `Borrow`" in `AsRef`'s docs to improve structure
Configuration menu - View commit details
-
Copy full SHA for 0e025ba - Browse repository at this point
Copy the full SHA 0e025baView commit details -
Rollup merge of rust-lang#100470 - reitermarkus:patch-1, r=joshtriplett
Tweak `FpCategory` example order. Follow same order for variable declarations and assertions.
Configuration menu - View commit details
-
Copy full SHA for 34a0e3f - Browse repository at this point
Copy the full SHA 34a0e3fView commit details -
Rollup merge of rust-lang#101040 - danielhenrymantilla:no-bounds-for-…
…default-annotated-derive, r=joshtriplett Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds That is, given something like: ```rs // #[default] on a generic enum does not add `Default` bounds to the type params. #[derive(Default)] enum MyOption<T> { #[default] None, Some(T), } ``` then `MyOption<T> : Default`_as currently implemented_ only holds when `T : Default`, as reported by ``@5225225`` [over Zulip](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/.23.5Bderive.28Default.29.5D.20for.20enums.20with.20fields). This is contrary to [what the accepted RFC proposes](https://rust-lang.github.io/rfcs/3107-derive-default-enum.html#generated-bounds) (_i.e._, that `T` be allowed not to be itself `Default`), and indeed seems to be a rather unnecessary limitation.
Configuration menu - View commit details
-
Copy full SHA for b8232b1 - Browse repository at this point
Copy the full SHA b8232b1View commit details -
Rollup merge of rust-lang#101308 - nerdypepper:feature/is-ascii-octdi…
…git, r=joshtriplett introduce `{char, u8}::is_ascii_octdigit` This feature adds two new APIs: `char::is_ascii_octdigit` and `u8::is_ascii_octdigit`, under the feature gate `is_ascii_octdigit`. These methods are shorthands for `char::is_digit(self, 8)` and `u8::is_digit(self, 8)`: ```rust // core::char impl char { pub fn is_ascii_octdigit(self) -> bool; } // core::num impl u8 { pub fn is_ascii_octdigit(self) -> bool; } ``` --- Couple of things I need help understanding: - `const`ness: have I used the right attribute in this case? - is there a way to run the tests for `core::char` alone, instead of `./x.py test library/core`?
Configuration menu - View commit details
-
Copy full SHA for 1dfd3ab - Browse repository at this point
Copy the full SHA 1dfd3abView commit details -
Rollup merge of rust-lang#102486 - pierwill:middle-const-eval-err, r=…
…compiler-errors Add diagnostic struct for const eval error in `rustc_middle` Part of rust-lang#100717. r? `@ghost`
Configuration menu - View commit details
-
Copy full SHA for a3abc61 - Browse repository at this point
Copy the full SHA a3abc61View commit details