-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce UnordMap, UnordSet, and UnordBag (MCP 533) #102698
Conversation
448a3be
to
005af79
Compare
☔ The latest upstream changes (presumably #103228) made this pull request unmergeable. Please resolve the merge conflicts. |
005af79
to
8d7f17f
Compare
This comment has been minimized.
This comment has been minimized.
MCP 533: rust-lang/compiler-team#533 Also, as an example, substitute UnordMap for FxHashMap in used_trait_imports query result.
8d7f17f
to
9117ea9
Compare
r? compiler |
Hm, that didn't seem to work... |
Re-assignment doesn't to work right now. @lcnr, do you want to take a look at this? You seemed to have some interest on Zulip a few months ago. |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 9117ea9 with merge 8f2030cfc7fe4c36f7e41a7593c5d23356c06f5c... |
r? @lcnr |
r=me after perf. Is the end goal here to completely remove |
The MCP only states the goal of removing the |
☀️ Try build successful - checks-actions |
1 similar comment
☀️ Try build successful - checks-actions |
Queued 8f2030cfc7fe4c36f7e41a7593c5d23356c06f5c with parent cdd7afe, future comparison URL. |
Finished benchmarking commit (8f2030cfc7fe4c36f7e41a7593c5d23356c06f5c): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
Perf looks unchanged -- I don't think the two minor changes are real. @bors r=lncr |
Thanks for the review, @lncr! |
☀️ Test successful - checks-actions |
Finished benchmarking commit (607878d): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
These benchmarks are currently noisy so I think we're good here, @rustbot label: +perf-regression-triaged |
…r=lncr Introduce UnordMap, UnordSet, and UnordBag (MCP 533) This is the start of implementing [MCP 533](rust-lang/compiler-team#533). I followed `@eddyb's` suggestion of naming the collection types `Unord(Map/Set/Bag)` which is a bit easier to type than `Unordered(Map/Set/Bag)` r? `@eddyb`
This is the start of implementing MCP 533.
I followed @eddyb's suggestion of naming the collection types
Unord(Map/Set/Bag)
which is a bit easier to type thanUnordered(Map/Set/Bag)
r? @eddyb