-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make overlapping_impls
not generic
#102931
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 890604d513b63932410aa0540ac018fbc6a8a483 with merge c6f1f1a586c74317beb8604d1e8196c41203bc9d... |
890604d
to
03c538d
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 03c538da881a1231cf3f2d4528b109d9a24a03aa with merge 72c5a74962948aa4ef28312989e91fd1ddbcbdc1... |
overlapping_impls
overlapping_impls
not generic
☀️ Try build successful - checks-actions |
Queued 72c5a74962948aa4ef28312989e91fd1ddbcbdc1 with parent db0597f, future comparison URL. |
Finished benchmarking commit (72c5a74962948aa4ef28312989e91fd1ddbcbdc1): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
I'm inclined to merge as is, but the bootstrap timings are all red :-/ |
I'll take a closer look at this when I can. Ooh I hadn't noticed the bootstrap times 😤. I also need to fix the doc comment on the function if nothing else. |
(Note that the diesel regressions are likely noise) |
Could the bootstrap times also be an anomaly? Maybe run perf again to see? |
It's possible, maybe unlikely, but bootstrap has some variance indeed. But sure, we can run it again and check. It won't hurt and the queue is empty. @bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 03c538da881a1231cf3f2d4528b109d9a24a03aa with merge ca24e8e6411a3b12836e973fb7772b4c5fe67d28... |
☀️ Try build successful - checks-actions |
Queued ca24e8e6411a3b12836e973fb7772b4c5fe67d28 with parent fa0ca78, future comparison URL. |
Finished benchmarking commit (ca24e8e6411a3b12836e973fb7772b4c5fe67d28): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Looking good. |
This improves perf
03c538d
to
c4068c7
Compare
Okay, fixed the doc comment. Should be good to go! |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (75dbd5b): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
@rustbot label: +perf-regression-triaged |
Trying to win back perf from #101632.