Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to say that memory outside the AM is always exposed #103106

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Try to say that memory outside the AM is always exposed #103106

merged 2 commits into from
Oct 27, 2022

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Oct 16, 2022 •
edited
Loading

cc @Gankra @thomcc

I want to confidently tell people that they can use from_exposed_addr to get a pointer for doing MMIO and/or other hardware interactions done with volatile reads/writes at particular addresses outside the Rust AM. Currently, the docs indicate that would be UB.

With this change, now the docs indicate that this is intended to be a valid use of from_exposed_addr.

r? @RalfJung

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 16, 2022
@saethlin saethlin mentioned this pull request Oct 16, 2022
Merged
@RalfJung
Copy link
Member

LGTM, but let's involve @thomcc as well, also for the changes I suggested.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@thomcc
Copy link
Member

thomcc commented Oct 21, 2022

Looks great. Thank you for clarifying this. r=me once you've sufficiently resolved the outstanding debate about how precise you want the wording to be.

@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2022

Some changes occurred in src/tools/cargo

cc @ehuss

@saethlin
Copy link
Member Author

Dangit I did the thing

@saethlin @RalfJung
Try to say that memory outside the AM is always exposed
0c3ae7d 
Co-authored-by: Ralf Jung <post@ralfj.de>
@RalfJung
Copy link
Member

RalfJung commented Oct 26, 2022 •
edited
Loading

LGTM aside from the last nit, but let's also get a libs person to look at this.
r? @thomcc

@rust-highfive rust-highfive assigned thomcc and unassigned RalfJung Oct 26, 2022
@saethlin @RalfJung
Update library/core/src/ptr/mod.rs
bd94763 
Co-authored-by: Ralf Jung <post@ralfj.de>
@thomcc
Copy link
Member

thomcc commented Oct 27, 2022

This is a great improvement, thanks.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 27, 2022

📌 Commit bd94763 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#103106 - saethlin:from_exposed_docs, r=thomcc
06d52d7 
Try to say that memory outside the AM is always exposed

cc `@Gankra` `@thomcc`

I want to confidently tell people that they can use `from_exposed_addr` to get a pointer for doing MMIO and/or other hardware interactions done with volatile reads/writes at particular addresses outside the Rust AM. Currently, the docs indicate that would be UB.

With this change, now the docs indicate that this is intended to be a valid use of `from_exposed_addr`.

r? `@RalfJung`
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 27, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2022
@bors
Auto merge of rust-lang#103623 - matthiaskrgr:rollup-318yc1t, r=matth…
0da281b 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103035 (Even nicer errors from assert_unsafe_precondition)
 - rust-lang#103106 (Try to say that memory outside the AM is always exposed)
 - rust-lang#103475 (Make param index generation a bit more robust)
 - rust-lang#103525 (Move a wf-check into the site where the value is instantiated)
 - rust-lang#103564 (library: allow some unused things in Miri)
 - rust-lang#103586 (Process registered region obligation in `resolve_regions_with_wf_tys`)
 - rust-lang#103592 (rustdoc: remove redundant CSS selector `.notable-traits .notable`)
 - rust-lang#103593 (Remove an unused parser function (`Expr::returns`))
 - rust-lang#103611 (Add test for issue 103574)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0cd8714 into rust-lang:master Oct 27, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 27, 2022
@saethlin saethlin deleted the from_exposed_docs branch March 15, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc left review comments

@RalfJung RalfJung RalfJung left review comments

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@saethlin @rustbot @RalfJung @rust-log-analyzer @thomcc @bors @rust-highfive