Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Revert "Set effective visibilities for imports more precisely" #103249

Merged
merged 1 commit into from
Oct 23, 2022
Merged

resolve: Revert "Set effective visibilities for imports more precisely" #103249

merged 1 commit into from
Oct 23, 2022

Conversation

petrochenkov
Copy link
Contributor

In theory the change was correct, but in practice the use of import items in HIR is limited and hacky, and it expects that (effective) visibilities for all (up to) 3 IDs of the import are set to the value reflecting (effective) visibility of the whole syntactic use item rather than its individual components.

Fixes #102352
r? @oli-obk

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 19, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2022
@petrochenkov petrochenkov mentioned this pull request Oct 19, 2022
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Oct 19, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2022

📌 Commit ba4834c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2022
@bors
Auto merge of rust-lang#103431 - Dylan-DPC:rollup-oozfo89, r=Dylan-DPC
9be2f35 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#101293 (Recover when unclosed char literal is parsed as a lifetime in some positions)
 - rust-lang#101908 (Suggest let for assignment, and some code refactor)
 - rust-lang#103192 (rustdoc: Eliminate uses of `EarlyDocLinkResolver::all_traits`)
 - rust-lang#103226 (Check `needs_infer` before `needs_drop` during HIR generator analysis)
 - rust-lang#103249 (resolve: Revert "Set effective visibilities for imports more precisely")
 - rust-lang#103305 (Move some tests to more reasonable places)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0b3e018 into rust-lang:master Oct 23, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 23, 2022
@petrochenkov petrochenkov mentioned this pull request Nov 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

Regression: false positive from unreachable_pub lint
5 participants
@petrochenkov @oli-obk @bors @rust-highfive @rustbot