Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sysroot directories to be more clear #103286

Closed
wants to merge 24 commits into from
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8a97952
made changes to compile.rs to change the name
Oct 20, 2022
184b115
reverted changes, as earlier changes was appropriate
Oct 20, 2022
b5cd01a
made changes as per the suggestion
Oct 20, 2022
f3872aa
renamed stage0 to bootstrap-sysroot
Oct 20, 2022
3602282
empty commit to restart the build
Oct 20, 2022
29aa242
Merge branch 'master' into ISSUE#101961
Oct 20, 2022
e3b777f
renamed stage0 to bootstrap-sysroot in src/bootstrap/config.rs and ad…
Oct 20, 2022
cbf6c2c
changed version number to 3 and changed CHANGELOG.md
Oct 20, 2022
ca9d12a
updated the missing update in config.rs
Oct 20, 2022
44401f0
reveted deletion of some lines in compile.rs
Oct 20, 2022
3d26bd7
formatting
Oct 20, 2022
a0ffa72
made sysroot search as default and then the incremental stage{}-sysroot
Oct 20, 2022
76eff26
fixed breaking test related to stage0 name change
Oct 20, 2022
c8ca2a5
remove commented/unwanted code
Oct 20, 2022
bf0a9a8
fixed another instance of failing test
Oct 20, 2022
917093b
added sysroot to the next stage builds
Oct 20, 2022
cdac1c9
Merge branch 'master' into ISSUE#101961
Oct 22, 2022
151046d
Merge remote-tracking branch 'upstream/master' into ISSUE#101961
Oct 26, 2022
fb0eec9
changed ci script to take the namechange of sysroot directories
Oct 26, 2022
4525f55
appended sysroot to the stage2 as part of sysroot name change process
Oct 26, 2022
37548a7
added the miss changed on line 229
Oct 26, 2022
bce7057
Update src/bootstrap/CHANGELOG.md
chetankokil Oct 31, 2022
ff6483f
Merge branch 'master' into ISSUE#101961
chetankokil Nov 20, 2022
445253d
Update config.rs
chetankokil Nov 20, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bootstrap/bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,7 @@ def bin_root(self):
>>> rb.bin_root() == os.path.join("build", "devel", "stage0")
True
"""
subdir = "stage0"
subdir = "bootstrap-sysroot"
return os.path.join(self.build_dir, self.build, subdir)

def get_toml(self, key, section=None):
Expand Down
4 changes: 1 addition & 3 deletions src/bootstrap/compile.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1106,9 +1106,7 @@ impl Step for Sysroot {
let compiler = self.compiler;
let host_dir = builder.out.join(&compiler.host.triple);
let sysroot = if compiler.stage == 0 {
host_dir.join("stage0-sysroot")
} else if builder.download_rustc() {
host_dir.join("ci-rustc-sysroot")
jyn514 marked this conversation as resolved.
Show resolved Hide resolved
host_dir.join("bootstrap-sysroot")
} else {
host_dir.join(format!("stage{}", compiler.stage))
jyn514 marked this conversation as resolved.
Show resolved Hide resolved
};
Expand Down