Rollup of 11 pull requests #103502
Merged
Rollup of 11 pull requests #103502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule, added in 49e6db7, overrode a rule in normalize.css. https://github.com/rust-lang/rust/blob/49e6db7f3510a99ab3d3723b2430add985629c39/src/librustdoc/html/static/normalize.css#L169-L175 When normalize.css was updated, this rule went away. necolas/normalize.css@a8edd0c
…dler` Start using `unix_sigpipe` instead of `rustc_driver::set_sigpipe_handler`. After this has been merged, we can completely remove `rustc_driver::set_sigpipe_handler`. Verification of this change --------------------------- 1. Remove `#[unix_sigpipe = "sig_dfl"]` 1. Run `./x.py build` 1. Run `./build/aarch64-apple-darwin/stage1/bin/rustdoc --help | false` 1. Observe ICE 1. Add back `#[unix_sigpipe = "sig_dfl"]` 1. Run `./x.py build` 1. Run `./build/aarch64-apple-darwin/stage1/bin/rustdoc --help | false` 1. Observe ICE fixed
…sleywiser Fix assertion failed for break_last_token and trailing token Fixes rust-lang#103143
…=wesleywiser Change terminology for assoc method suggestions when they are not called Fixes rust-lang#103325 ```@rustbot``` label +A-diagnostics
…n-ice, r=cjgillot
Don't ICE when reporting borrowck errors involving regions from `anonymous_lifetime_in_impl_trait`
The issue here is that when we have:
```
trait Trait<'a> { .. }
fn foo(arg: impl Trait) { .. }
```
The anonymous lifetime `'_` that we generate for `arg: impl Trait` doesn't end up in the argument type (which is a param) but in a where-clause of the function, in a predicate whose self type is that param ty.
Fixes rust-lang#101660
r? ``@cjgillot``
…ismatch, r=lcnr Delay span bug when we can't map lifetimes back in `collect_trait_impl_trait_tys` When a lifetime is late-bound in a trait signature, but early-bound in an impl signature, we already emit an error -- however, we also ICE in `collect_trait_impl_trait_tys`, so just delay a bug here. Fixes rust-lang#103407
…ohnTitor -Z docs: Add link to unstable book
…t-white-space, r=Dylan-DPC
rustdoc: remove no-op CSS `.source pre.rust { white-space: pre }`
This rule, added in 49e6db7, overrode a rule in normalize.css.
https://github.com/rust-lang/rust/blob/49e6db7f3510a99ab3d3723b2430add985629c39/src/librustdoc/html/static/normalize.css#L169-L175
When normalize.css was updated, this rule went away.
necolas/normalize.css@a8edd0c
E0210 explanation: remove redundant sentence
…-highlight-colors, r=notriddle Use functions in highlight-colors rustdoc GUI test r? ``@notriddle``
…-logo, r=GuillaumeGomez rustdoc: remove unused `.sidebar-logo` DOM on source pages
…er, r=GuillaumeGomez rustdoc: remove redundant CSS `a.test-arrow:hover` In 4b402db, when this rule was added, it was overriding a rule that made all links in docblock get an underline when hovered. This became redundant when, after reordering the rules, 7585632 changed the pro-underline rule to exclude the test-arrow link anyway.
…triddle rustdoc: Use `unix_sigpipe` instead of `rustc_driver::set_sigpipe_handler` Do what was already done for `rustc` in rust-lang#102587, namely start using `unix_sigpipe` instead of `rustc_driver::set_sigpipe_handler`. After this has been merged, we can completely remove `rustc_driver::set_sigpipe_handler`. PR that added `set_sigpipe_handler`: rust-lang#49606 Tracking issue for `unix_sigpipe`: rust-lang#97889 Verification of this change --------------------------- 1. Remove `#[unix_sigpipe = "sig_dfl"]` 1. Run `./x.py build` 1. Run `./build/aarch64-apple-darwin/stage1/bin/rustdoc --help | false` 1. Observe ICE 1. Add back `#[unix_sigpipe = "sig_dfl"]` 1. Run `./x.py build` 1. Run `./build/aarch64-apple-darwin/stage1/bin/rustdoc --help | false` 1. Observe ICE fixed ``@rustbot`` labels +T-rustdoc
rustbot
added
T-compiler
|
@bors r+ p=11 rollup=never |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 758f19645b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (f2702e9): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
anonymous_lifetime_in_impl_trait#103382 (Don't ICE when reporting borrowck errors involving regions fromanonymous_lifetime_in_impl_trait)collect_trait_impl_trait_tys#103409 (Delay span bug when we can't map lifetimes back incollect_trait_impl_trait_tys).source pre.rust { white-space: pre }#103462 (rustdoc: remove no-op CSS.source pre.rust { white-space: pre }).sidebar-logoDOM on source pages #103493 (rustdoc: remove unused.sidebar-logoDOM on source pages)a.test-arrow:hover#103494 (rustdoc: remove redundant CSSa.test-arrow:hover)unix_sigpipeinstead ofrustc_driver::set_sigpipe_handler#103495 (rustdoc: Useunix_sigpipeinstead ofrustc_driver::set_sigpipe_handler)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup