Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover from common if let syntax mistakes/typos #103636

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Recover from common if let syntax mistakes/typos #103636

merged 3 commits into from
Nov 10, 2022

Conversation

chenyukang
Copy link
Member

Fixes #103587

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2022

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@chenyukang chenyukang mentioned this pull request Oct 27, 2022
Closed
@chenyukang chenyukang force-pushed the yukang/fix-103587-sugg-if-let branch from 6039b40 to ca4927a Compare October 27, 2022 16:22
@jackh726
Copy link
Member

jackh726 commented Nov 7, 2022

LGTM with subdiagnostic added

@jackh726 jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2022
@bors

This comment was marked as resolved.

Sign in to view
@chenyukang chenyukang force-pushed the yukang/fix-103587-sugg-if-let branch 2 times, most recently from afe93c6 to 9e7d228 Compare November 8, 2022 15:37
@davidtwco
Copy link
Member

@bors r=jackh276,davidtwco

@bors
Copy link
Contributor

bors commented Nov 8, 2022

📌 Commit 9e7d228 has been approved by jackh276,davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2022
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 8, 2022
@Manishearth
Rollup merge of rust-lang#103636 - chenyukang:yukang/fix-103587-sugg-…
0dfd52b 
…if-let, r=jackh276,davidtwco

Recover from common if let syntax mistakes/typos

Fixes rust-lang#103587
@Manishearth Manishearth mentioned this pull request Nov 8, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 8, 2022
@Manishearth
Rollup merge of rust-lang#103636 - chenyukang:yukang/fix-103587-sugg-…
1053217 
…if-let, r=jackh276,davidtwco

Recover from common if let syntax mistakes/typos

Fixes rust-lang#103587
@Manishearth Manishearth mentioned this pull request Nov 8, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 8, 2022
@Manishearth
Rollup merge of rust-lang#103636 - chenyukang:yukang/fix-103587-sugg-…
c4526d8 
…if-let, r=jackh276,davidtwco

Recover from common if let syntax mistakes/typos

Fixes rust-lang#103587
@Manishearth Manishearth mentioned this pull request Nov 8, 2022
Closed
@chenyukang
Copy link
Member Author

@bors r-

#104176 (comment)

@Manishearth How to run this single test case in local?
Seems this command not working:

x test ./src/tools/clippy/tests/ui/crashes/ice-6250.rs --bless

@Manishearth
Copy link
Member

That ought to work, perhaps ask on Zulip? I wouldn't know without seeing more of the error.

@davidtwco
Copy link
Member

@Manishearth How to run this single test case in local? Seems this command not working:

x test ./src/tools/clippy/tests/ui/crashes/ice-6250.rs --bless

Wouldn't it be more like x test ./src/tools/clippy/ --test-args ice-6250 --bless?

@chenyukang
Copy link
Member Author

@Manishearth How to run this single test case in local? Seems this command not working:

x test ./src/tools/clippy/tests/ui/crashes/ice-6250.rs --bless

Wouldn't it be more like x test ./src/tools/clippy/ --test-args ice-6250 --bless?

No, not working...

cat@LAPTOP-V6U0QKD4:~/code/rust$  x test ./src/tools/clippy/ --test-args ice-6250 --bless
Building rustbuild
    Finished dev [unoptimized] target(s) in 0.04s
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.21s
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.20s
Copying stage0 rustc from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Assembling stage1 compiler (x86_64-unknown-linux-gnu)
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.14s
Copying stage1 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.19s
Copying stage1 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
Building stage1 tool clippy-driver (x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.15s
Building rustdoc for stage1 (x86_64-unknown-linux-gnu)
    Finished release [optimized + debuginfo] target(s) in 0.15s
    Finished release [optimized + debuginfo] target(s) in 0.18s
     Running unittests src/driver.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/clippy_driver-613db7c0b8c82598)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/check-fmt.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/check_fmt-7dc715d9b3ea3888)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/compile-test.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/compile_test-a1006319e4c0efbe)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 3 filtered out; finished in 0.00s

     Running tests/dogfood.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/dogfood-4d21110a169a32d8)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/integration.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/integration-0664f500aaf92777)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/lint_message_convention.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/lint_message_convention-c7b02f26e4d0bb14)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/missing-test-files.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/missing_test_files-cfe393cf71d33d5d)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

     Running tests/versioncheck.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/versioncheck-6c900a9e1e2297ff)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 2 filtered out; finished in 0.00s

     Running tests/workspace.rs (build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/deps/workspace-b27e5604761ba5c8)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

Build completed successfully in 0:00:02

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@chenyukang
Copy link
Member Author

Got it by this way:

x.py test --help --verbose | grep clippy

Then:

./x.py test src/tools/clippy --bless

@jyn514
Copy link
Member

jyn514 commented Nov 9, 2022

Clippy is a special snowflake and uses TESTNAME to tell it how to run individual tests instead of an argument to compiletest. I need to integrate it with x.py at some point. For now you can use TESTNAME=ice-6250 x test src/tools/clippy --bless.

I think this would also be fixed by #103266.

@chenyukang
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2022
@davidtwco
Copy link
Member

@bors r=jackh276,davidtwco

@bors
Copy link
Contributor

bors commented Nov 9, 2022

📌 Commit 91b4e7c has been approved by jackh276,davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2022
@jyn514 jyn514 mentioned this pull request Nov 9, 2022
Open
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 10, 2022
@Manishearth
Rollup merge of rust-lang#103636 - chenyukang:yukang/fix-103587-sugg-…
47b7512 
…if-let, r=jackh276,davidtwco

Recover from common if let syntax mistakes/typos

Fixes rust-lang#103587
@Manishearth Manishearth mentioned this pull request Nov 10, 2022
Closed
@bors
Copy link
Contributor

bors commented Nov 10, 2022

⌛ Testing commit 91b4e7c with merge 11fa085...

@bors
Copy link
Contributor

bors commented Nov 10, 2022

☀️ Test successful - checks-actions
Approved by: jackh276,davidtwco
Pushing 11fa085 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2022
@bors bors merged commit 11fa085 into rust-lang:master Nov 10, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 10, 2022
This was referenced Nov 10, 2022
Merged
Merged
Closed
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (11fa085): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.1% [1.4%, 2.8%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.1% [2.8%, 3.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#103636 - chenyukang:yukang/fix-103587-sugg-if…
1ff5e2e 
…-let, r=jackh276,davidtwco

Recover from common if let syntax mistakes/typos

Fixes rust-lang#103587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@jackh726 jackh726

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Recover from common if let syntax mistakes/typos
9 participants
@chenyukang @rustbot @jackh726 @bors @davidtwco @Manishearth @jyn514 @rust-timer @compiler-errors