Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "system" ABI #10367

Merged
merged 1 commit into from
Nov 9, 2013
Merged

Add a "system" ABI #10367

merged 1 commit into from
Nov 9, 2013

Conversation

alexcrichton
Copy link
Member

This adds an other ABI option which allows a custom selection over the target
architecture and OS. The only current candidate for this change is that kernel32
on win32 uses stdcall, but on win64 it uses the cdecl calling convention.
Otherwise everywhere else this is defined as using the Cdecl calling convention.

cc #10049
Closes #8774

@alexcrichton
Copy link
Member Author

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

r+ with typo fixed (deliberately placed this comment on PR, not commit)

bors added a commit that referenced this pull request Nov 9, 2013
This adds an other ABI option which allows a custom selection over the target
architecture and OS. The only current candidate for this change is that kernel32
on win32 uses stdcall, but on win64 it uses the cdecl calling convention.
Otherwise everywhere else this is defined as using the Cdecl calling convention.

cc #10049
Closes #8774
This adds an other ABI option which allows a custom selection over the target
architecture and OS. The only current candidate for this change is that kernel32
on win32 uses stdcall, but on win64 it uses the cdecl calling convention.
Otherwise everywhere else this is defined as using the Cdecl calling convention.

cc rust-lang#10049
Closes rust-lang#8774
bors added a commit that referenced this pull request Nov 9, 2013
This adds an other ABI option which allows a custom selection over the target
architecture and OS. The only current candidate for this change is that kernel32
on win32 uses stdcall, but on win64 it uses the cdecl calling convention.
Otherwise everywhere else this is defined as using the Cdecl calling convention.

cc #10049
Closes #8774
@bors bors closed this Nov 9, 2013
@bors bors merged commit 2fcc70e into rust-lang:master Nov 9, 2013
@alexcrichton alexcrichton deleted the system-abi branch November 10, 2013 23:04
zargony added a commit to zargony/fuse-rs that referenced this pull request Nov 11, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 10, 2023
Fix ICE in `multiple_unsafe_ops_per_block`

fixes rust-lang#10367

changelog: [`multiple_unsafe_ops_per_block`]: Fix ICE when calling a function-like object in an unsafe block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a platform-dependent calling convention alias
3 participants