Rollup of 5 pull requests #103841

Dylan-DPC · 2022-11-01T16:31:39Z

Successful merges:

Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error #84022 (Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error)
resolve: Turn the binding from #[macro_export] into a proper Import #103760 (resolve: Turn the binding from #[macro_export] into a proper Import)
rustdoc: remove unnecessary CSS .search-results { clear: both } #103813 (rustdoc: remove unnecessary CSS .search-results { clear: both })
rustdoc: rename syntax highlighting CSS class attribute to attr #103817 (rustdoc: rename syntax highlighting CSS class attribute to attr)
⬆️ rust-analyzer #103833 (:arrow_up: rust-analyzer)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…rting

fix: Don't respond with an error when requesting a shutdown while starting

…e it is being invoked for

fix: Fix standard flycheck command not being executed in the workspace it is being invoked for Fixes rust-lang/rust-analyzer#13477

…, r=flodiebold fix: Test all generic args for trait when finding matching impl Addresses rust-lang/rust-analyzer#13463 (comment) When finding matching impl for a trait method, we've been testing the unifiability of self type. However, there can be multiple impl of a trait for the same type with different generic arguments for the trait. This patch takes it into account and tests the unifiability of all type arguments for the trait (the first being the self type) thus enables rust-analyzer to find the correct impl even in such cases.

Switch to upstream `positionEncoding` Closes rust-lang#13481 This drops support for the custom extension, but that's probably fine. Draft because it's not tested yet.

feat: type inference for generic associated types This PR implements type inference for generic associated types. Basically, this PR lowers generic arguments for associated types in valid places and creates `Substitution`s for them. I focused on the inference for correct Rust programs, so there are cases where we *accidentally* manage to infer things that are actually invalid (which would then be reported by flycheck so I deem them non-fatal). See the following tests and FIXME notes on them: `gats_with_dyn`, `gats_with_impl_trait`. The added tests are rather arbitrary. Let me know if there are cases I'm missing or I should add. Closes rust-lang#9673

…hievink internal: Clarify feature policy CC rust-lang#13495

feat: Clicking the status bar item stops and starts the server

Always set up VSCode commands

…eykril Properly handle vscode workspace changes

Clean up tests and add documentation for GATs related stuff This is a follow-up PR for rust-lang#13494. - addresses rust-lang/rust-analyzer#13494 (comment) - documents the ordering constraint on `Binders` and `Substitution` (which is not really follow-up for the previous PR, but it was introduced to support GATs and I strongly feel it's worth it)

Since the tabs use flexbox instead of float as of 44d9b8d, clearing does nothing.

Link classes use the abbreviation `attr`, so why shouldn't syntax highlighting?

…k, r=petrochenkov Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error r? `@ghost`

resolve: Turn the binding from `#[macro_export]` into a proper `Import` Continuation of rust-lang#91795. ```rust #[macro_export] macro_rules! m { /*...*/ } ``` is desugared to something like ```rust macro_rules! m { /*...*/ } // Non-modularized macro_rules item pub use m; // It's modularized reexport ``` This PR adjusts the internal representation to better match this model.

…-clear-both, r=GuillaumeGomez rustdoc: remove unnecessary CSS `.search-results { clear: both }` Since the tabs use flexbox instead of float as of 44d9b8d, clearing does nothing.

… r=GuillaumeGomez rustdoc: rename syntax highlighting CSS class `attribute` to `attr` Link classes use the abbreviation `attr` ... https://github.com/rust-lang/rust/blob/2afca78a0b03db144c5d8b9f8868feebfe096309/src/librustdoc/html/static/css/rustdoc.css#L255-L259 ... so why does syntax highlighting use the full word? https://github.com/rust-lang/rust/blob/2afca78a0b03db144c5d8b9f8868feebfe096309/src/librustdoc/html/static/css/rustdoc.css#L1095-L1097

…r=lnicola ⬆️ rust-analyzer r? `@ghost`

Dylan-DPC · 2022-11-01T16:31:51Z

@bors r+ rollup=never p=5

bors · 2022-11-01T16:31:53Z

📌 Commit 2b10891 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-11-01T18:15:36Z

⌛ Testing commit 2b10891 with merge ab5a2bc...

bors · 2022-11-01T21:09:38Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing ab5a2bc to master...

rust-timer · 2022-11-01T21:11:11Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#103833	b9e1c12e3f62c53762903c5dca9e220cf286f582
#103817	34b8190d7e55f0a090f4d6376947362545986161
#103813	8c250f95e2f7485d435d88245828769f96484a03
#103760	e418a044dfe47ef6422a4b0bbc28279af757add2
#84022	70400b28c93e366a380b746b17a51f1951acd5fe

previous master: 4c736a21ae

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-11-01T22:30:11Z

Finished benchmarking commit (ab5a2bc): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.6%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.8%, -1.7%]	7
All ❌✅ (primary)	0.5%	[0.4%, 0.6%]	8

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

lqd · 2022-11-02T08:47:13Z

The deeply-nested-multi wins are likely noise. But there's not much else in this rollup, let's see if the #[macro_export] change has impacted expansion for libc-0.2.124

@rust-timer build e418a044dfe47ef6422a4b0bbc28279af757add2

rust-timer · 2022-11-02T08:47:16Z

Queued e418a044dfe47ef6422a4b0bbc28279af757add2 with parent 4c736a2, future comparison URL.

rust-timer · 2022-11-02T11:15:41Z

Finished benchmarking commit (e418a044dfe47ef6422a4b0bbc28279af757add2): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.3%, 0.5%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.3%, 0.5%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.8%	[-0.8%, -0.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	-	-	0

rylev · 2022-11-02T14:22:15Z

Seems like #103760 is the culprit. cc @petrochenkov @cjgillot

lowr and others added 30 commits October 24, 2022 21:30

Refactor: unwrap Option once in the beginning of closure

6afd0f5

fix: Don't respond with an error when requesting a shutdown while sta…

6a00e14

…rting

Auto merge of rust-lang#13476 - Veykril:prefer-shutdown, r=Veykril

98aa678

fix: Don't respond with an error when requesting a shutdown while starting

fix: Fix standard flycheck command not being executed in the workspac…

fbae83a

…e it is being invoked for

Auto merge of rust-lang#13478 - Veykril:fix-flycheck, r=Veykril

53b6d69

fix: Fix standard flycheck command not being executed in the workspace it is being invoked for Fixes rust-lang/rust-analyzer#13477

Let InferenceTable::unify() relate Zip values

15d4383

Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error

7d82cad

Switch to upstream positionEncoding

956b96a

Pin lsp-types

e93a2bf

Test all generic args for trait when finding matching impl

67f1d8f

Auto merge of rust-lang#13484 - lnicola:position-encoding, r=lnicola

0340b51

Switch to upstream `positionEncoding` Closes rust-lang#13481 This drops support for the custom extension, but that's probably fine. Draft because it's not tested yet.

refactor: remove obsolete code

1fe10bf

Display generic arguments for associated types

4dd6943

Lower generic arguments for associated types in paths

f233ac4

Collect generic arguments in associated type bindings

63cba43

Lower generic arguments for GATs in associated type bindings

5fc18ad

Clarify feature policy

05514d8

Auto merge of rust-lang#13496 - rust-lang:lnicola-patch-1, r=jonas-sc…

d022e0e

…hievink internal: Clarify feature policy CC rust-lang#13495

Replace expect test for GATs with check_types

5c79421

Document the ordering constraint on Binders and Substitution

e0f09cd

feat: Clicking the status bar item stops and starts the server

274df54

Auto merge of rust-lang#13510 - Veykril:status-click, r=Veykril

e69014a

feat: Clicking the status bar item stops and starts the server

Always set up VSCode commands

2071d00

Auto merge of rust-lang#13512 - Veykril:startup-commands, r=Veykril

7610ee9

Always set up VSCode commands

Properly handle vscode workspace changes

fccf8eb

Auto merge of rust-lang#13513 - Veykril:vscode-workspace-changes, r=V…

ebce5e9

…eykril Properly handle vscode workspace changes

resolve: Not all imports have their own NodeId

637bfe6

notriddle and others added 8 commits October 31, 2022 11:53

rustdoc: remove unnecessary CSS .search-results { clear: both }

5e64804

Since the tabs use flexbox instead of float as of 44d9b8d, clearing does nothing.

rustdoc: rename syntax highlighting CSS class attribute to attr

6432bb7

Link classes use the abbreviation `attr`, so why shouldn't syntax highlighting?

⬆️ rust-analyzer

0b3e75e

Rollup merge of rust-lang#84022 - Aaron1011:remove-derive-res-fallbac…

9f603fe

…k, r=petrochenkov Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error r? `@ghost`

Rollup merge of rust-lang#103813 - notriddle:notriddle/search-results…

db200d0

…-clear-both, r=GuillaumeGomez rustdoc: remove unnecessary CSS `.search-results { clear: both }` Since the tabs use flexbox instead of float as of 44d9b8d, clearing does nothing.

Rollup merge of rust-lang#103833 - lnicola:rust-analyzer-2022-11-01, …

2b10891

…r=lnicola ⬆️ rust-analyzer r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 1, 2022

bors merged commit ab5a2bc into rust-lang:master Nov 1, 2022

rustbot added this to the 1.67.0 milestone Nov 1, 2022

bors mentioned this pull request Nov 1, 2022

resolve/effective-visibility: Stop recalculating current normal module #103688

Closed

rustbot added the perf-regression Performance regression. label Nov 1, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #103841

Rollup of 5 pull requests #103841

Dylan-DPC commented Nov 1, 2022

Dylan-DPC commented Nov 1, 2022

bors commented Nov 1, 2022

bors commented Nov 1, 2022

bors commented Nov 1, 2022

rust-timer commented Nov 1, 2022

rust-timer commented Nov 1, 2022

lqd commented Nov 2, 2022

rust-timer commented Nov 2, 2022

rust-timer commented Nov 2, 2022

rylev commented Nov 2, 2022

Rollup of 5 pull requests #103841

Rollup of 5 pull requests #103841

Conversation

Dylan-DPC commented Nov 1, 2022

Dylan-DPC commented Nov 1, 2022

bors commented Nov 1, 2022

bors commented Nov 1, 2022

bors commented Nov 1, 2022

rust-timer commented Nov 1, 2022

rust-timer commented Nov 1, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

lqd commented Nov 2, 2022

rust-timer commented Nov 2, 2022

rust-timer commented Nov 2, 2022

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

rylev commented Nov 2, 2022