Don't remap early-bound regions for return-position impl Trait in trait originating from impl
#103852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
rpitit-early-from-impl
branch
from
addfff8 to
72fbb54
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…impl, r=lcnr Don't remap early-bound regions for return-position `impl Trait` in trait originating from `impl` long title 😓 We don't want to remap early-bound regions that originate from the `impl`s themselves, since they have no corresponding region in the trait. Not sure if there's a better condition than checking if the EBR's def-id's parent is the impl -- maybe we should be checking if the region comes from the method or RPITIT... 🤷 r? types Fixes rust-lang#103850
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…impl, r=lcnr Don't remap early-bound regions for return-position `impl Trait` in trait originating from `impl` long title 😓 We don't want to remap early-bound regions that originate from the `impl`s themselves, since they have no corresponding region in the trait. Not sure if there's a better condition than checking if the EBR's def-id's parent is the impl -- maybe we should be checking if the region comes from the method or RPITIT... 🤷 r? types Fixes rust-lang#103850
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 17, 2022
…impl, r=lcnr Don't remap early-bound regions for return-position `impl Trait` in trait originating from `impl` long title 😓 We don't want to remap early-bound regions that originate from the `impl`s themselves, since they have no corresponding region in the trait. Not sure if there's a better condition than checking if the EBR's def-id's parent is the impl -- maybe we should be checking if the region comes from the method or RPITIT... 🤷 r? types Fixes rust-lang#103850
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#103852 (Don't remap early-bound regions for return-position `impl Trait` in trait originating from `impl`) - rust-lang#104366 (Simplify settings theme choice) - rust-lang#104433 (Fix `emit_unused_delims_expr` ICE) - rust-lang#104444 (Fix ICE in in_operand for ty error) - rust-lang#104483 (Convert predicates into Predicate in the Obligation constructor) - rust-lang#104496 (Don't attempt to normalize compiler backtraces) - rust-lang#104503 (rustdoc: remove redundant font-color CSS on `.where`) - rust-lang#104508 (Check `dyn*` return type correctly) - rust-lang#104515 (ICE fixing, remove is_tainted_by_errors since we have ty_error for delay bug) - rust-lang#104532 (Migrate tooltip style to CSS variables) - rust-lang#104545 (Readd the matches_macro diag item) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long title 😓
We don't want to remap early-bound regions that originate from the
impls themselves, since they have no corresponding region in the trait. Not sure if there's a better condition than checking if the EBR's def-id's parent is the impl -- maybe we should be checking if the region comes from the method or RPITIT... 🤷r? types
Fixes #103850