Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs of RefCell #103881

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Clarify docs of RefCell #103881

merged 1 commit into from
Dec 28, 2022

Conversation

ChayimFriedman2
Copy link
Contributor

Comparison operators only panic if the RefCell is mutably borrowed, and RefCell::swap() can also panic if swapping a RefCell with itself.

@ChayimFriedman2
Clarify docs of RefCell
d2eb2bb 
Comparison operators only panic if the `RefCell` is mutably borrowed, and `RefCell::swap()` can also panic if swapping a `RefCell` with itself.
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 2, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@inquisitivecrystal inquisitivecrystal added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Nov 4, 2022
@compiler-errors
Copy link
Member

These are good clarifications, afaict not controversial.

r? @compiler-errors @bors r+

@bors
Copy link
Contributor

bors commented Dec 27, 2022

📌 Commit d2eb2bb has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#103881 - ChayimFriedman2:patch-2, r=compile…
4894b2a 
…r-errors

Clarify docs of `RefCell`

Comparison operators only panic if the `RefCell` is mutably borrowed, and `RefCell::swap()` can also panic if swapping a `RefCell` with itself.
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 28, 2022
Closed
@bors
Copy link
Contributor

bors commented Dec 28, 2022

⌛ Testing commit d2eb2bb with merge 9b889e5...

@bors
Copy link
Contributor

bors commented Dec 28, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 9b889e5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 28, 2022
@bors bors merged commit 9b889e5 into rust-lang:master Dec 28, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 28, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9b889e5): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [-2.1%, 2.5%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@compiler-errors
Copy link
Member

Regression is definitely noise

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#103881 - ChayimFriedman2:patch-2, r=compiler-…
128840a 
…errors

Clarify docs of `RefCell`

Comparison operators only panic if the `RefCell` is mutably borrowed, and `RefCell::swap()` can also panic if swapping a `RefCell` with itself.
@ChayimFriedman2 ChayimFriedman2 deleted the patch-2 branch August 4, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ChayimFriedman2 @rustbot @compiler-errors @bors @rust-timer @m-ou-se @inquisitivecrystal