Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups around scalar layout restrictions #103917

Merged
merged 17 commits into from
Nov 27, 2022
Merged

Various cleanups around scalar layout restrictions #103917

merged 17 commits into from
Nov 27, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 3, 2022

Pulled out of #103724

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 3, 2022

@bors try @rust-timer queue

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 3, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 3, 2022
@bors
Copy link
Contributor

bors commented Nov 3, 2022

⌛ Trying commit 3278c3dfc02a9862c90d90c573cdde96ae4f4236 with merge a5ad1e28c77b80ed8339ab36c1438ffc121baafb...

@bors
Copy link
Contributor

bors commented Nov 3, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 3, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Nov 3, 2022

⌛ Trying commit 27b1a1b3cd52254253f8b7d0558a81d21231a447 with merge 22364409b0e2dc95fcad50cce48558d1354bbfa7...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
RalfJung
RalfJung reviewed Nov 3, 2022
View reviewed changes
src/test/ui/lint/invalid_value.stderr Outdated
... |
LL | | #[stable(feature = "signed_nonzero", since = "1.34.0")] #[rustc_const_stable(feature = "signed_nonzero", since = "1.34.0")] NonZeroIs...
LL | | }
| |_^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a terrible span.^^ I deliberately made it not show spans for restricted layout types before.

@lcnr
Copy link
Contributor

lcnr commented Nov 3, 2022

r? @RalfJung as you're already reviewing it

@rustbot rustbot assigned RalfJung and unassigned lcnr Nov 3, 2022
@RalfJung
Copy link
Member

RalfJung commented Nov 5, 2022 •
edited
Loading

r=me on the lint changes, though I am not entirely convinced they are all improvements.

However there are also some logic changes in compiler/rustc_ty_utils/src/layout.rs and I don't know anything about that code nor do I understand what is being changed or why here, so I can't review that -- sorry. r? @lcnr for that part.

oli-obk added 16 commits November 25, 2022 07:51
@oli-obk
Prefer not accessing the private field of newtype_index types
2a94a2d
@oli-obk
Some manual formatting of let..else statements
2b8963a
@oli-obk
rustc_layout_scalar_valid_range can be applied to scalar pairs and …
c3eb8f2 
…affects teh first scalar
@oli-obk
More manual formatting
6773e7e
@oli-obk
Make the ICEs in the mir typechecker have more spans helpful
9909cb9
@oli-obk
Print a trace through types to show how to get to the problematic type
5cbf172
@oli-obk
Compute layout instead of manually procesisng the layout restriction …
2bed079 
…attributes
@oli-obk
Don't try to compute the layout of generic types.
ccaa28b
@oli-obk
Add a test for scalar pair layout validation
545fcca
@oli-obk
Reinstate the previous compact form of "in this field" errors
98c550e
@oli-obk
Move a comment to the right place
2e79f5f
@oli-obk
Don't show fields from other crates
fcb1f18
@oli-obk
Simplify and document range layout computation
d7f5d78
@oli-obk
Add a test for OOB ranges
9b6f8e5
@oli-obk
Add a because to errors derived from fields
5446a52
@oli-obk
Use "must be init" instead of "must not be uninit" everywhere
208bb93
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 25, 2022

@bors r=RalfJung,lcnr

@bors
Copy link
Contributor

bors commented Nov 25, 2022

📌 Commit 208bb93 has been approved by RalfJung,lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 25, 2022
@bors
Copy link
Contributor

bors commented Nov 27, 2022

⌛ Testing commit 208bb93 with merge df04d28...

@bors
Copy link
Contributor

bors commented Nov 27, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung,lcnr
Pushing df04d28 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 27, 2022
@bors bors merged commit df04d28 into rust-lang:master Nov 27, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 27, 2022
This was referenced Nov 27, 2022
Merged
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (df04d28): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@oli-obk oli-obk deleted the layout_math branch November 27, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

@RalfJung RalfJung RalfJung left review comments

Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
7 participants
@oli-obk @rustbot @rust-timer @bors @rust-log-analyzer @lcnr @RalfJung