Retry binding TCP Socket in remote-test-server #104146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
|
I'm not sure that a retry flag is needed; I think we can just make the retry behavior unconditional. It seems like in most cases it's either harmless or helpful. |
Sure, I can do that. How many retries should be done before giving up? For UEFI, I mostly use 5. |
|
Five seems fine. |
This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning. This was orignally implemented in rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Ayush1325
force-pushed
the
remote-test-server
branch
from
4c76201
to
06a77af
Compare
Ayush1325
changed the title
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 10, 2022
…n514 Retry binding TCP Socket in remote-test-server This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning. This was orignally implemented in rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 10, 2022
…n514 Retry binding TCP Socket in remote-test-server This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning. This was orignally implemented in rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…n514 Retry binding TCP Socket in remote-test-server This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning. This was orignally implemented in rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
…n514 Retry binding TCP Socket in remote-test-server This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning. This was orignally implemented in rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Nov 11, 2022
…n514 Retry binding TCP Socket in remote-test-server This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning. This was orignally implemented in rust-lang#100316 Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 11, 2022
Rollup of 9 pull requests Successful merges: - rust-lang#100633 (Consider `#[must_use]` annotation on `async fn` as also affecting the `Future::Output`) - rust-lang#103445 (`#[test]`: Point at return type if `Termination` bound is unsatisfied) - rust-lang#103924 (Fix broken link in description of error code E0706) - rust-lang#104146 (Retry binding TCP Socket in remote-test-server) - rust-lang#104169 (Migrate `:target` rules to use CSS variables) - rust-lang#104202 (Fix ICE rust-lang#103748) - rust-lang#104216 (Don't ICE on operator trait methods with generic methods) - rust-lang#104217 (Display help message when fluent arg was referenced incorrectly) - rust-lang#104245 (Reduce default configuration's dependency upon static libstdcpp library (rust-lang#103606)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows retrying binding TCP Socket multiple times. This is useful when using emulators as network might not be available in the beginning.
This was orignally implemented in #100316
Signed-off-by: Ayush Singh ayushsingh1325@gmail.com