Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EarlyBinder docs #104194

Merged
merged 2 commits into from
Nov 10, 2022
Merged

EarlyBinder docs #104194

merged 2 commits into from
Nov 10, 2022

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Nov 9, 2022

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2022
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 9, 2022

📌 Commit 4c197c0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2022
notriddle added a commit to notriddle/rust that referenced this pull request Nov 10, 2022
@notriddle
Rollup merge of rust-lang#104194 - BoxyUwU:early_binder_docs, r=compi…
a26b48a 
…ler-errors

`EarlyBinder` docs
@notriddle notriddle mentioned this pull request Nov 10, 2022
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Nov 10, 2022
@Manishearth
Rollup merge of rust-lang#104194 - BoxyUwU:early_binder_docs, r=compi…
f7b8884 
…ler-errors

`EarlyBinder` docs
@Manishearth Manishearth mentioned this pull request Nov 10, 2022
Closed
@compiler-errors
Copy link
Member

compiler-errors commented Nov 10, 2022 •
edited
Loading

Failed in a rollup since the intra-doc link is incorrect. Not sure how best to test this, but there should be a way to do so -- once that's done r=me.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2022
@wesleywiser
Copy link
Member

I believe if you x.py doc it will show the same failure.

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Nov 10, 2022

im so mad I literally ran x.py doc locally because I wanted to check links 😐 I really wish we would catch this in CI

@wesleywiser
Copy link
Member

Oh, I'm probably wrong then. Sorry for the noise!

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Nov 10, 2022

No no you're right I just missed it..

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Nov 10, 2022

broken lints is a warning when you do x doc so I must have ran x doc then it "succeeded" and I thought everythign was fine...

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Nov 10, 2022

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Nov 10, 2022

📌 Commit 2566701 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 10, 2022
@Manishearth Manishearth mentioned this pull request Nov 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 10, 2022
@bors
Auto merge of rust-lang#104246 - Manishearth:rollup-9o3txc7, r=Manish…
a3c0a02 
…earth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101939 (Add loongarch64 abi support)
 - rust-lang#103863 (Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor)
 - rust-lang#104036 (Suggest `is_some` when we've found `Option` but expected `bool`)
 - rust-lang#104060 (Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher`)
 - rust-lang#104077 (Use aapcs for efiapi calling convention on arm)
 - rust-lang#104186 (Tighten the 'introduce new binding' suggestion)
 - rust-lang#104194 (`EarlyBinder` docs)
 - rust-lang#104233 (Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor`)
 - rust-lang#104235 (Use `const_error_with_guaranteed` more)

Failed merges:

 - rust-lang#104078 (Print "Checking/Building ..." message even when --dry-run is passed)
 - rust-lang#104169 (Migrate `:target` rules to use CSS variables)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c6595ea into rust-lang:master Nov 10, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@BoxyUwU @rustbot @compiler-errors @bors @wesleywiser