Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequiredConstsVisitor is not needed when error happens in mir_promoted #104234

Closed
wants to merge 1 commit into from
Closed

RequiredConstsVisitor is not needed when error happens in mir_promoted #104234

wants to merge 1 commit into from

Conversation

chenyukang
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2022

r? @fee1-dead

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@compiler-errors
Copy link
Member

compiler-errors commented Nov 10, 2022 •
edited
Loading

Although not noted in the PR, I'm pretty sure this is a different strategy to solve #104209, which is also addressed in #104233. Not sure which is better strategy (I don't particularly care), but regardless this PR needs a "fixes ##" note and a UI test.

@chenyukang
Copy link
Member Author

Although not noted in the PR, this is a different strategy to solve #104209, which is also addressed in #104233. Not sure which is better strategy (I don't particularly care), but regardless this PR needs a "fixes ##" note and a UI test.

Yes, I was investigating #104209, but this change can not fix that issue.
My next fix is same as you, but since you submitted a PR for that, I removed it to avoid conflict 😁

@compiler-errors
Copy link
Member

Hm -- If this PR does not fix anything or change observable behavior, I think it should be closed then, since it's not useful on its own.

@chenyukang
Copy link
Member Author

Ok, closing it.

@chenyukang chenyukang closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fee1-dead fee1-dead

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenyukang @rustbot @compiler-errors @fee1-dead