Remove xray and improve some error messages #10427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the removal of privacy from resolve, this flag is no longer necessary to get the test runner working. All of the privacy checks are bypassed by a special item attribute in the privacy visitor. Closes rust-lang#4947
|
The word 'block' here isn't clear to me. Would 'closure' or even 'closure block' be a more descriptive word for where the error is occurring? |
|
Updated to |
|
Failed test is checking for the old error message. ( |
Before it was always stated that it was a "break outside of a loop" when you could very well be in a loop, but just in a block instead. Closes rust-lang#3064
bors
added a commit
that referenced
this pull request
Nov 12, 2013
Just a few triage issues that I ran into.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 10, 2023
Update version attribute for 1.68 lints Roses are red, violets are blue, I'm running out of rhymes, changelogs are crimes???? --- changelog: none <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few triage issues that I ran into.