Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walk types more carefully in ProhibitOpaqueTypes visitor #104296

Merged

Conversation

compiler-errors
Copy link
Member

The visitor didn't account for the case where you could have <TAIT as Trait>::Assoc normalize to itself, in the case of a type TAIT = impl Trait with an unconstrained associated type. That causes the visitor to loop on the same type over and over.

Fixes #104291

@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2022

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 11, 2022
@lcnr
Copy link
Contributor

lcnr commented Nov 14, 2022

would it be better to first normalize the whole type, and then only search for opaque types instead of lazily normalizing projections?

no matter whether you want to change that

r=me

@compiler-errors
Copy link
Member Author

Oh, lol, I didn't see this comment:

// Consider opaque types within projections FFI-safe if they do not normalize
// to more opaque types.

I thought we wanted to trigger when we see an opaque in the un-normalized projection. Yeah, normalizing first is much easier lol.

@compiler-errors compiler-errors force-pushed the opaque-ty-ffi-normalization-cycle branch from 669d57d to d8bd153 Compare November 15, 2022 03:45
@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Nov 15, 2022

📌 Commit d8bd153 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2022
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103439 (Show note where the macro failed to match)
 - rust-lang#103734 (Adjust stabilization version to 1.65.0 for wasi fds)
 - rust-lang#104148 (Visit attributes of trait impl items during AST validation)
 - rust-lang#104241 (Move most of unwind's build script to lib.rs)
 - rust-lang#104258 (Deduce closure signature from a type alias `impl Trait`'s supertraits)
 - rust-lang#104296 (Walk types more carefully in `ProhibitOpaqueTypes` visitor)
 - rust-lang#104309 (Slightly improve error message for invalid identifier)
 - rust-lang#104316 (Simplify suggestions for errors in generators.)
 - rust-lang#104339 (Add `rustc_deny_explicit_impl`)

Failed merges:

 - rust-lang#103484 (Add `rust` to `let_underscore_lock` example)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d8b416d into rust-lang:master Nov 15, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 15, 2022
@compiler-errors compiler-errors deleted the opaque-ty-ffi-normalization-cycle branch August 11, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TAIT crash: stack overflow in check_for_opaque_ty
4 participants