Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #104481

Merged
merged 26 commits into from
Nov 16, 2022
Merged

Rollup of 10 pull requests #104481

merged 26 commits into from
Nov 16, 2022

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    2484a18 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ff010b View commit details
    Browse the repository at this point in the history
  3. Update let_underscore.rs

    saschanaz authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    6b5f275 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6279d09 View commit details
    Browse the repository at this point in the history
  5. fix the lint as requested

    saschanaz committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    8ecbb7e View commit details
    Browse the repository at this point in the history
  6. Fix failing examples

    saschanaz committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    30b5223 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Configuration menu
    Copy the full SHA
    5fd561d View commit details
    Browse the repository at this point in the history
  2. Fix test/ui/issues/issue-30490.rs

    Since the empty main is used for `not(unix)`, all the targets that will
    use this empty main will also need `allow(unused_imports)`.
    
    Originally part of rust-lang#100316
    
    Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
    Ayush1325 committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    55746a4 View commit details
    Browse the repository at this point in the history
  3. rustdoc: remove no-op CSS .popover { font-size: 1rem }

    This rule was added in cc4f804 because the help popover inherited the
    font-size from the help button "?" icon.
    
    It doesn't inherit this any more, because it was moved from being nested
    inside the link to sharing a wrapper DIV with it.
    notriddle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    8b34675 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd84709 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    70ad2f5 View commit details
    Browse the repository at this point in the history
  6. rustdoc: remove no-op CSS .main-header { justify-content }

    This rule was added in 152e888 to push the
    out-of-band content to the right while allowing it to line wrap when it got
    too big. The idea was that the justification rule would fill the space
    between the `<h1>` element and the `<div class="out-of-band">` element.
    
    A later commit, 3cb03cb, flattened the
    in-band element into the `<h1>`, copying the `flex-grow` rule. This means
    the `<h1>` element now grows to fill the space, so there's no need to
    justify-content any more.
    
    This commit also adds a test case for this.
    notriddle committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    155a553 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. shift no characters when using raw string literals

    remove `find_skips`
    
    remove unnecessary variables
    TaKO8Ki committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    9857de2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6211faa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a528b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Update PROBLEMATIC_CONSTS in style.rs

    added 3735932941, since 3735927486 was already present.
    scruss authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e6e29a8 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#103484 - saschanaz:patch-2, r=ehuss

    Add `rust` to `let_underscore_lock` example
    
    Currently https://doc.rust-lang.org/beta/rustc/lints/listing/deny-by-default.html#let-underscore-lock has no colored grammar and raw `{{produces}}` command is exposed.
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5140bbd View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#103489 - WaffleLapkin:byte_offset_from_you,…

    … r=scottmcm
    
    Make `pointer::byte_offset_from` more generic
    
    As suggested by rust-lang#96283 (comment) (cc ````@scottmcm),```` make `pointer::byte_offset_from` work on pointers of different types. `byte_offset_from` really doesn't care about pointer types, so this is totally fine and, for example, allows patterns like this:
    ```rust
    ptr::addr_of!(x.b).byte_offset_from(ptr::addr_of!(x))
    ```
    
    The only possible downside is that this removes the `T` == `U` hint to inference, but I don't think this matter much. I don't think there are a lot of cases where you'd want to use `byte_offset_from` with a pointer of unbounded type (and in such cases you can just specify the type).
    
    ````@rustbot```` label +T-libs-api
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    91963cc View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#104193 - TaKO8Ki:fix-104142, r=cjgillot

    Shift no characters when using raw string literals
    
    Fixes rust-lang#104142
    
    Given the following code:
    
    ```rust
    fn main() {
        println!(r#"\'\'\'\'\'\'\'\'\'\'\'\'\'\'}"#);
    }
    ```
    
    The current output is:
    
    ```
    error: invalid format string: unmatched `}` found
     --> src/main.rs:2:59
      |
    2 |     println!(r#"\'\'\'\'\'\'\'\'\'\'\'\'\'\'}"#); //~ ERROR invalid format string: unmatched `}` found
      |                                                           ^ unmatched `}` in format string
      |
      = note: if you intended to print `}`, you can escape it using `}}`
    
    error: could not compile `debug_playground` due to previous error
    ```
    
    The output should look like:
    
    ```
    error: invalid format string: unmatched `}` found
     --> src/main.rs:2:45
      |
    2 |     println!(r#"\'\'\'\'\'\'\'\'\'\'\'\'\'\'}"#); //~ ERROR invalid format string: unmatched `}` found
      |                                             ^ unmatched `}` in format string
      |
      = note: if you intended to print `}`, you can escape it using `}}`
    
    error: could not compile `debug_playground` due to previous error
    ```
    
    This pull request fixes the wrong span for `invalid format string` error and also solves the ICE.
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    88a1919 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#104348 - fmease:iat-vis-stab, r=cjgillot

    Respect visibility & stability of inherent associated types
    
    As discussed in rust-lang#103621, this probably won't be the final location of the code that resolves inherent associated types. Still, I think it's valuable to push correctness fixes for this feature (in regards to visibility and stability).
    
    Let me know if I should write a translatable diagnostic instead and if I should move the tests to `privacy/` and `stability-attribute/` respectively.
    
    Fixes rust-lang#104243.
    ````@rustbot```` label A-visibility F-inherent_associated_types
    r? ````@cjgillot```` (since you reviewed rust-lang#103621, feel free to reroll though)
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3a8cacd View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#104401 - RalfJung:mpsc-leak, r=Amanieu

    avoid memory leak in mpsc test
    
    r? ```@Amanieu```
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    4864a04 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#104419 - Ayush1325:test-issue-30490, r=lcnr

    Fix test/ui/issues/issue-30490.rs
    
    Since the empty main is used for `not(unix)`, all the targets that will use this empty main will also need `allow(unused_imports)`.
    
    Originally part of rust-lang#100316
    
    Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    4ef422e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#104424 - notriddle:notriddle/popover-font-s…

    …ize, r=GuillaumeGomez
    
    rustdoc: remove no-op CSS `.popover { font-size: 1rem }`
    
    This rule was added in cc4f804 because the help popover inherited the font-size from the help button "?" icon.
    
    It doesn't inherit this any more, because it was moved from being nested inside the link to sharing a wrapper DIV with it.
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    b9d028a View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#104425 - notriddle:notriddle/main-heading-j…

    …ustify-content, r=GuillaumeGomez
    
    rustdoc: remove no-op CSS `.main-header { justify-content }`
    
    This rule was added in 152e888 to push the out-of-band content to the right while allowing it to line wrap when it got too big. The idea was that the justification rule would fill the space between the `<h1>` element and the `<div class="out-of-band">` element.
    
    A later commit, 3cb03cb, flattened the in-band element into the `<h1>`, copying the `flex-grow` rule. This means the `<h1>` element now grows to fill the space, so there's no need to justify-content any more.
    
    This commit also adds a test case for this.
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    25c3180 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#104450 - andrewpollack:fix-fuchsia-compiler…

    …-docs, r=tmandry
    
    Fuchsia test suite script fix
    
    Fixing error from rust-lang#103842 (comment)
    
    r? ```@tmandry```
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    c32d79c View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#104471 - scruss:patch-1, r=jyn514

    Update PROBLEMATIC_CONSTS in style.rs
    
    added 3735932941, since 3735927486 was already present.
    matthiaskrgr authored Nov 16, 2022
    Configuration menu
    Copy the full SHA
    8bbecb9 View commit details
    Browse the repository at this point in the history