Fix emit_unused_delims_expr ICE
#105004
Merged
Fix emit_unused_delims_expr ICE
#105004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
wesleywiser
reviewed
Nov 28, 2022
| } | ||
| let mut visitor = ErrExprVisitor { has_error: false }; | ||
| visitor.visit_expr(value); | ||
| if visitor.has_error { |
There was a problem hiding this comment.
Can you leave a comment here explaining why we do this check?
fmt add a comment
wesleywiser
approved these changes
Dec 6, 2022
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 6, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#104898 (Put all cached values into a central struct instead of just the stable hash) - rust-lang#105004 (Fix `emit_unused_delims_expr` ICE) - rust-lang#105174 (Suggest removing struct field from destructive binding only in shorthand scenario) - rust-lang#105250 (Replace usage of `ResumeTy` in async lowering with `Context`) - rust-lang#105286 (Add -Z maximal-hir-to-mir-coverage flag) - rust-lang#105320 (rustdoc: simplify CSS selectors on top-doc and non-exhaustive toggles) - rust-lang#105349 (Point at args in associated const fn pointers) - rust-lang#105362 (Cleanup macro-expanded code in `rustc_type_ir`) - rust-lang#105370 (Remove outdated syntax from trait alias pretty printing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104897
This is also related to #104433.