-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #105070
Rollup of 14 pull requests #105070
Conversation
They can cause issues in e.g. cargo.
suggestion from a friend!! 🐸 Co-authored-by: Michael Goulet <michael@errs.io>
it doesn't belong there as it also does winnowing
type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds fixes rust-lang#103642 rust-lang#102417 only made sure that hidden types cannot outlive lifetimes other than the ones mentioned on bounds, but didn't allow us to actually infer anything from that. cc `@aliemjay`
…ail-actually, r=lcnr Explain why `rematch_impl` fails to be infallible Fixes rust-lang#104395 r? `@lcnr`
…ated-string-comment, r=Mark-Simulacrum Add slice to the stack allocated string comment Precise that the "stack allocated string" is not a string but a string slice. ``@rustbot`` label +A-docs
…leywiser Don't use periods in target names Using a period in the target name can cause issues in e.g. cargo, see also https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Running.20tests.20on.20remote.20target
…s, r=compiler-errors Print all features with --print target-features This fixes `rustc --print target-features` with respect to aliases and tied features. Before this change, the print command assumed that each LLVM feature corresponds exactly to one rustc feature. In the case of aliases and tied features, this assumption failed and some features (such as aarch64's "pacg") were missing. With this change, every target feature is listed.
…-return-clause, r=oli-obk Make inferred_outlives_crate return Clause r? ``@oli-obk``
Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str` Implements rust-lang/libs-team#140 (tracking issue rust-lang#105021).
…r=wesleywiser Statics used in reachable function's inline asm are reachable Fixes rust-lang#104925.
…ler-errors `rustc_ast_{passes,pretty}`: remove `ref` patterns r? `@compiler-errors` Previous PR: rust-lang#104721
Hermit: Minor build fixes These changes are necessary to build for the hermit targets. CC: ``@stlankes``
Replace a macro with a function 🌸
…-background, r=GuillaumeGomez rustdoc: use shorthand background for rustdoc toggle CSS
… r=compiler-errors move `candidate_from_obligation` out of assembly it doesn't belong there as it also does winnowing r? `@compiler-errors`
Run patchelf also on rust-analyzer-proc-macro-srv. On NixOS, `rust-analyzer-proc-macro-srv` needs to be `patchelf`ed just like all the other libs and binaries. With this fix, I am able to use the language server configuration recommended in [the guide](https://rustc-dev-guide.rust-lang.org/building/suggested.html#configuring-rust-analyzer-for-rustc).
@bors r+ rollup=never p=14 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: bddad597fe In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (d38a990): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
The primary regressions on |
Successful merges:
rematch_impl
fails to be infallible #104427 (Explain whyrematch_impl
fails to be infallible)PathBuf::as_mut_os_string
andPath::as_mut_os_str
#105002 (AddPathBuf::as_mut_os_string
andPath::as_mut_os_str
)rustc_ast_{passes,pretty}
: removeref
patterns #105045 (rustc_ast_{passes,pretty}
: removeref
patterns)candidate_from_obligation
out of assembly #105066 (movecandidate_from_obligation
out of assembly)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup