-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #105444
Rollup of 9 pull requests #105444
Commits on Nov 28, 2022
-
Detect long types in E0308 and write them to disk
On type error with long types, print an abridged type and write the full type to disk. Print the widest possible short type while still fitting in the terminal.
Configuration menu - View commit details
-
Copy full SHA for 7674ede - Browse repository at this point
Copy the full SHA 7674edeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 360c0a7 - Browse repository at this point
Copy the full SHA 360c0a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73b371a - Browse repository at this point
Copy the full SHA 73b371aView commit details -
Configuration menu - View commit details
-
Copy full SHA for be02bd9 - Browse repository at this point
Copy the full SHA be02bd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 360bcb6 - Browse repository at this point
Copy the full SHA 360bcb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34b3c49 - Browse repository at this point
Copy the full SHA 34b3c49View commit details
Commits on Dec 1, 2022
-
kmc-solid: Use
expose_addr
andfrom_exposed_addr
for pointer-inte……ger casts Pointer-integer casts are required for conversion between `EXINF` (ITRON task entry point parameter) and `*const ThreadInner`. Addresses the deny-level lint `fuzzy_provenance_casts`.
Configuration menu - View commit details
-
Copy full SHA for 427a079 - Browse repository at this point
Copy the full SHA 427a079View commit details -
kmc-solid: Add a stub implementation of
is_terminal
Copied from `unsupported/io.rs`. Fixes build failure.
Configuration menu - View commit details
-
Copy full SHA for 47f2f6d - Browse repository at this point
Copy the full SHA 47f2f6dView commit details -
kmc-solid: Address compiler warnings
Addresses the warn-by-default lints `unused_imports` and `unused_unsafe`.
Configuration menu - View commit details
-
Copy full SHA for f482e55 - Browse repository at this point
Copy the full SHA f482e55View commit details
Commits on Dec 2, 2022
-
kmc-solid: Don't do
Box::from_raw(&*(x: Box<T>) as *const T as *mut T)
This pattern seems to be considered illegal by Miri.
Configuration menu - View commit details
-
Copy full SHA for ae7633f - Browse repository at this point
Copy the full SHA ae7633fView commit details
Commits on Dec 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e2d41f4 - Browse repository at this point
Copy the full SHA e2d41f4View commit details
Commits on Dec 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9397ea1 - Browse repository at this point
Copy the full SHA 9397ea1View commit details -
Stacked Borrows: factor the logic determining the new permissions on …
…retag into a separate function
Configuration menu - View commit details
-
Copy full SHA for 34c58e8 - Browse repository at this point
Copy the full SHA 34c58e8View commit details
Commits on Dec 7, 2022
-
Add help for
#![feature(impl_trait_in_fn_trait_return)]
This adds a new variant `ImplTraitContext::FeatureGated`, so we can generalize the help for `return_position_impl_trait_in_trait` to also work for `impl_trait_in_fn_trait_return`.
Configuration menu - View commit details
-
Copy full SHA for e9dd591 - Browse repository at this point
Copy the full SHA e9dd591View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0669379 - Browse repository at this point
Copy the full SHA 0669379View commit details -
Configuration menu - View commit details
-
Copy full SHA for eef61b4 - Browse repository at this point
Copy the full SHA eef61b4View commit details -
Improve several aspects of the Rustdoc scrape-examples UI.
* Examples take up less screen height. * Snippets from binary crates are prioritized. * toggle-all-docs does not expand "More examples" sections.
Configuration menu - View commit details
-
Copy full SHA for 6ccd14a - Browse repository at this point
Copy the full SHA 6ccd14aView commit details -
Configuration menu - View commit details
-
Copy full SHA for acd70e6 - Browse repository at this point
Copy the full SHA acd70e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4574217 - Browse repository at this point
Copy the full SHA 4574217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 679d7ea - Browse repository at this point
Copy the full SHA 679d7eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 212d03d - Browse repository at this point
Copy the full SHA 212d03dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae270f1 - Browse repository at this point
Copy the full SHA ae270f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcdab87 - Browse repository at this point
Copy the full SHA bcdab87View commit details -
Fix rustdoc error with no providec crate-type, fix scrape examples bu…
…tton colors w/ themes
Configuration menu - View commit details
-
Copy full SHA for 0709e53 - Browse repository at this point
Copy the full SHA 0709e53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a45938 - Browse repository at this point
Copy the full SHA 8a45938View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9499d2c - Browse repository at this point
Copy the full SHA 9499d2cView commit details -
CI: add missing line continuation marker
Resolves this docker warning: ``` [WARNING]: Empty continuation line found in: RUN apt-get update && apt-get install -y --no-install-recommends g++ gcc-multilib make ninja-build file curl ca-certificates python2.7 python3.9 git cmake sudo gdb llvm-13-tools llvm-13-dev libedit-dev libssl-dev pkg-config zlib1g-dev xz-utils nodejs apt-transport-https software-properties-common && curl -s "https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/packages-microsoft-prod.deb" > packages-microsoft-prod.deb && dpkg -i packages-microsoft-prod.deb && apt-get update && apt-get install -y powershell && rm -rf /var/lib/apt/lists/* Warning: : Empty continuation lines will become errors in a future release. ```
Configuration menu - View commit details
-
Copy full SHA for 8bc30cb - Browse repository at this point
Copy the full SHA 8bc30cbView commit details
Commits on Dec 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a3c4c2e - Browse repository at this point
Copy the full SHA a3c4c2eView commit details -
Rollup merge of rust-lang#104922 - estebank:fur-elize, r=oli-obk
Detect long types in E0308 and write them to disk On type error with long types, print an abridged type and write the full type to disk. Print the widest possible short type while still fitting in the terminal.
Configuration menu - View commit details
-
Copy full SHA for 27c0dd6 - Browse repository at this point
Copy the full SHA 27c0dd6View commit details -
Rollup merge of rust-lang#105120 - solid-rs:patch/kmc-solid/maintaina…
…nce, r=thomcc kmc-solid: `std::sys` code maintenance Includes a set of changes to fix the [`*-kmc-solid_*`](https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html) Tier 3 targets and make some other improvements. - Address `fuzzy_provenance_casts` by using `expose_addr` and `from_exposed_addr` for pointer-integer casts - Add a stub implementation of `is_terminal` (rust-lang#98070) - Address `unused_imports` and `unused_unsafe` - Stop doing `Box::from_raw(&*(x: Box<T>) as *const T as *mut T)`
Configuration menu - View commit details
-
Copy full SHA for ee74286 - Browse repository at this point
Copy the full SHA ee74286View commit details -
Rollup merge of rust-lang#105255 - cjgillot:issue-105197, r=compiler-…
…errors Make nested RPIT inherit the parent opaque's generics. Fixes rust-lang#105197 r? `@compiler-errors`
Configuration menu - View commit details
-
Copy full SHA for b47fc78 - Browse repository at this point
Copy the full SHA b47fc78View commit details -
Rollup merge of rust-lang#105317 - RalfJung:retag-rework, r=oli-obk
make retagging work even with 'unstable' places This is based on top of rust-lang#105301. Only the last two commits are new. While investigating rust-lang/unsafe-code-guidelines#381 I realized that we would have caught this issue much earlier if the add_retag pass wouldn't bail out on assignments of the form `*ptr = ...`. So this PR changes our retag strategy: - When a new reference is created via `Rvalue::Ref` (or a raw ptr via `Rvalue::AddressOf`), we do the retagging as part of just executing that address-taking operation. - For everything else, we still insert retags -- these retags basically serve to ensure that references stored in local variables (and their fields) are always freshly tagged, so skipping this for assignments like `*ptr = ...` is less egregious. r? `@oli-obk`
Configuration menu - View commit details
-
Copy full SHA for 55e07fd - Browse repository at this point
Copy the full SHA 55e07fdView commit details -
Rollup merge of rust-lang#105387 - willcrichton:scrape-examples-ui-im…
…provements, r=notriddle Improve Rustdoc scrape-examples UI This PR combines a few different improvements to the scrape-examples UI. See a live demo here: https://willcrichton.net/misc/scrape-examples/small-first-example/clap/struct.Arg.html ### 1. The first scraped example now takes up significantly less screen height. Inserting the first scraped example takes up a lot of vertical screen space. I don't want this addition to overwhelm users, so I decided to reduce the height of the initial example in two ways: (A) the default un-expanded height is reduced from 240px (10 LOC) to 120px (5 LOC), and (B) the link to the example is now positioned *over* the example instead of *atop* the example (only on desktop though, not mobile). The changes to `scrape-examples.js` and `rustdoc.css` implement this fix. Here is what an example docblock now looks like: ![Screen Shot 2022-12-06 at 10 02 21 AM](https://user-images.githubusercontent.com/663326/205987450-3940063c-5973-4a34-8579-baff6a43aa9b.png) ### 2. Expanding all docblocks will not expand "More examples". The "More examples blocks" are huge, so fully expanding everything on the page would take up too much vertical space. The changes to `main.js` implement this fix. This is tested in `scrape-examples-toggle.goml`. ### 3. Examples from binary crates are sorted higher than examples from library crates. Code that is written as an example of an API is probably better for learning than code that happens to use an API, but isn't intended for pedagogic purposes. Unfortunately Rustc doesn't know whether a particular crate comes from an example target (only Cargo knows this). But we can at least create a proxy that prefers examples from binary crates over library crates, which we know from `--crate-type`. This change is implemented by adding a new field `bin_crate` in `Options` (see `config.rs`). An `is_bin` field has been added to the scraped examples metadata (see `scrape_examples.rs`). Then the example sorting metric uses `is_bin` as the first entry of a lexicographic sort on `(is_bin, example_size, display_name)` (see `render/mod.rs`). Note that in the future we can consider adding another flag like `--scrape-examples-cargo-target` that would pass target information from Cargo into the example metadata. But I'm proposing a less intrusive change for now. ### 4. The scrape-examples help page has been updated to reflect the latest Cargo interface. See `scrape-examples-help.md`. r? `@notriddle` P.S. once this PR and rust-lang/cargo#11450 are merged, then I think the scrape-examples feature is officially ready for deployment on docs.rs!
Configuration menu - View commit details
-
Copy full SHA for 23ea785 - Browse repository at this point
Copy the full SHA 23ea785View commit details -
Rollup merge of rust-lang#105408 - cuviper:help-rpitirpit, r=compiler…
…-errors Add help for `#![feature(impl_trait_in_fn_trait_return)]` This adds a new variant `ImplTraitContext::FeatureGated`, so we can generalize the help for `return_position_impl_trait_in_trait` to also work for `impl_trait_in_fn_trait_return`. cc rust-lang#99697
Configuration menu - View commit details
-
Copy full SHA for 616a11a - Browse repository at this point
Copy the full SHA 616a11aView commit details -
Rollup merge of rust-lang#105427 - GuillaumeGomez:dont-silently-ignor…
…e-rustdoc-errors, r=notriddle Dont silently ignore rustdoc errors I applied the suggestions from rust-lang#104995 and also checked the rustdoc-ui error but couldn't reproduce it. r? `@notriddle`
Configuration menu - View commit details
-
Copy full SHA for b475163 - Browse repository at this point
Copy the full SHA b475163View commit details -
Rollup merge of rust-lang#105433 - ComputerDruid:docker_continuation_…
…fix, r=jyn514 CI: add missing line continuation marker Resolves this docker warning: ``` [WARNING]: Empty continuation line found in: RUN apt-get update && apt-get install -y --no-install-recommends g++ gcc-multilib make ninja-build file curl ca-certificates python2.7 python3.9 git cmake sudo gdb llvm-13-tools llvm-13-dev libedit-dev libssl-dev pkg-config zlib1g-dev xz-utils nodejs apt-transport-https software-properties-common && curl -s "https://packages.microsoft.com/config/ubuntu/$(lsb_release -rs)/packages-microsoft-prod.deb" > packages-microsoft-prod.deb && dpkg -i packages-microsoft-prod.deb && apt-get update && apt-get install -y powershell && rm -rf /var/lib/apt/lists/* Warning: : Empty continuation lines will become errors in a future release. ```
Configuration menu - View commit details
-
Copy full SHA for 9289c92 - Browse repository at this point
Copy the full SHA 9289c92View commit details -
Rollup merge of rust-lang#105434 - nbdd0121:lib, r=thomcc
Fix warning when libcore is compiled with no_fp_fmt_parse Discovered when trying to compile Rust-for-Linux with Rust 1.66 beta. It'll be helpful if this is backported to beta (should be trivial enough for backporting), so Rust-for-Linux's rust version bump wouldn't need to do `--cap-lints allow` for libcore.
Configuration menu - View commit details
-
Copy full SHA for a147868 - Browse repository at this point
Copy the full SHA a147868View commit details