rustdoc: Fix badge alignment

[GuillaumeGomez]

It fixes a bug discovered by @joshtriplett.

It'll conflict with #105504 so I'll just rebase once the conflict arises. :)

r? @notriddle

[rustbot]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

[joshtriplett]

Should this use "middle" or "baseline"? It seems like the latter would work better given that the fonts may be somewhat different.

[notriddle]

1. They're guaranteed to be different, because Fira Sans is used for the link, while Source Code Serif is used for the badge.

2. Not a fan of wildcard selectors. It's too tricky to figure out what they're actually supposed to target.

[GuillaumeGomez]

Middle:

Baseline:

I tend to prefer the "middle" alignment because "baseline" renders weirdly since even though they share the same baseline, they don't have the same height, making it a bit weird for the eye (imo). For "middle", they are vertically aligned which I find more pleasant.

[GuillaumeGomez]

Well in short, I have a preference for the "middle" alignment but don't have a strong opinion about it so as is preferred.

@notriddle: I updated the selector to make it more specific.

[bors]

☔ The latest upstream changes (presumably #105512) made this pull request unmergeable. Please resolve the merge conflicts.

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between a161a7b654083a881b22908a475988bcc3221a79 and 3736c4596d07c7a54bd53550527ec561a62f764d
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
.......... (90/92)
..         (92/92)


/checkout/src/test/rustdoc-gui/stab-badge.goml stab-badge... FAILED
[ERROR] (line 6) Error: Evaluation failed: The following errors happened (for XPath `//*[@class='item-table']//*[@class='item-left module-item']/*[@class='stab deprecated']`): [expected `2px` for key `padding-top`, found `0px`]: for command `assert-css: (
    "//*[@class='item-table']//*[@class='item-left module-item']/*[@class='stab deprecated']",
    {"padding-top": "2px"},
)`
[ERROR] (line 10) Error: Evaluation failed: The following errors happened: [different Y values: 1891.390625 (or 1891) != 1892]: for command `assert-position: (
    "//*[@class='item-table']//*[@class='item-left module-item']/*[@class='stab deprecated']",
    {"y": 1892},
)`
[ERROR] (line 14) Error: Evaluation failed: The following errors happened: [different Y values: 1891.890625 (or 1892) != 1894]: for command `assert-position: (
    "//*[@class='item-table']//*[@class='item-left module-item']/*[@class='stab deprecated']/preceding-sibling::a",
    {"y": 1894}, // 1892 + 2 because of padding

Build completed unsuccessfully in 0:02:04

[anden3]

Hello @GuillaumeGomez! I just want to ping you as part of the triage procedure as this PR has merge conflicts and CI failures :)

[GuillaumeGomez]

Seems like it needs to be discussed more so closing.