Prevent redundant casts and create fewer LLVM builders #105549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit 121fd41 with merge 90a90c32dad6513d8aa5922981091031aab10159... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
tmiasko
reviewed
Dec 11, 2022
Comment on lines
+839
to
+843
| if llvm::LLVMTypeOf(val) != dest_ty { | ||
| llvm::LLVMBuildPointerCast(self.llbuilder, val, dest_ty, UNNAMED) | ||
| } else { | ||
| val | ||
| } |
There was a problem hiding this comment.
Doesn't builder fold this at construction already https://github.com/rust-lang/llvm-project/blob/3dfd4d93fa013e1c0578d3ceac5c8f4ebba4b6ec/llvm/include/llvm/IR/IRBuilder.h#L1998-L2005?
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
This seems like a nice improvement, but I'm probably not the best choice to review this. r? compiler |
workingjubilee
removed
the
S-waiting-on-perf
|
☔ The latest upstream changes (presumably #109862) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents redundant bit/pointer/int casts being codegen'd by LLVM and reduces the number of LLVM builders that are created through the course of code generation