Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor grammar nit. #105642

Closed
wants to merge 1 commit into from
Closed

Minor grammar nit. #105642

wants to merge 1 commit into from

Conversation

uberFoo
Copy link
Contributor

@uberFoo uberFoo commented Dec 12, 2022

I was browsing the documentation and noticed that this should be an adverb.

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 13, 2022

📌 Commit c3329ba has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#105642 - uberFoo:master, r=Dylan-DPC
c69a12e 
Minor grammar nit.

I was browsing the documentation and noticed that this should be an adverb.
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#105642 - uberFoo:master, r=Dylan-DPC
549ba2e 
Minor grammar nit.

I was browsing the documentation and noticed that this should be an adverb.
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2022
@bors
Auto merge of rust-lang#105690 - matthiaskrgr:rollup-khtq97k, r=matth…
ba64ba8 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105642 (Minor grammar nit.)
 - rust-lang#105658 (Remove ..X from RELEASES.md)
 - rust-lang#105663 (Adjust log line in `fuchsia-test-runner.py`)
 - rust-lang#105664 (rustdoc: apply `pre-wrap` CSS to code-wrapped links)
 - rust-lang#105665 (rustdoc: simplify popover CSS)
 - rust-lang#105676 (rustdoc: add CSS margin between `impl` docblock and its items)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@JohnTitor
Copy link
Member

This has been merged in rollup but hasn't been marked as merged because the author pushed a commit while rollup'ing.
@uberFoo Next time be careful when a reviewer does r+!
Closing as the change itself has been merged successfully.

@JohnTitor JohnTitor closed this Dec 21, 2022
@uberFoo
Copy link
Contributor Author

uberFoo commented Dec 21, 2022

It would be great if you could help me understand what I did wrong. The only commit I intentionally made was the initial one.

@JohnTitor
Copy link
Member

You force-pushed while a rollup PR was open, which changed the commit SHA, and GitHub couldn't mark this PR as merged.

@uberFoo
Copy link
Contributor Author

uberFoo commented Dec 21, 2022 •
edited
Loading

That’s the part I don’t understand. I don’t know how I managed to do that. I don’t remember touching anything after the initial PR. Was this a push to my PR, or my local branch. Forgive the newb questions, but I am one. I’ve never worked with a project this complex.

min other words, I’ll never do it again. I just need to figure out exactly what it was that I did.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@uberFoo @rustbot @Dylan-DPC @bors @JohnTitor @joshtriplett