Point at method chains on E0271 errors
#105674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
estebank
force-pushed
the
iterator-chains
branch
2 times, most recently
from
5c62917 to
7907144
Compare
This comment was marked as resolved.
This comment was marked as resolved.
oli-obk
reviewed
Dec 14, 2022
| @@ -30,7 +30,7 @@ LL | where | |||
| LL | F: for<'r> T0<'r, (<Self as Ty<'r>>::V,), O = <B as Ty<'r>>::V>, | |||
| | ^^^^^^^^^^^^^^^^^^^^ required by this bound in `T1::m` | |||
|
|
|||
| error[E0271]: expected `[closure@$DIR/issue-62203-hrtb-ice.rs:42:16: 42:19]` to be a closure that returns `Unit3`, but it returns `Unit4` | |||
| error[E0271]: expected `[closure@issue-62203-hrtb-ice.rs:42:16]` to be a closure that returns `Unit3`, but it returns `Unit4` | |||
There was a problem hiding this comment.
We should probably be pointing at the closure's span in such diagnostics. (separate PR)
|
r=me after a rebase |
estebank
force-pushed
the
iterator-chains
branch
2 times, most recently
from
62d01b7 to
7f8fdf4
Compare
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2022
Point at method chains on `E0271` errors Follow up to rust-lang#105332. Fix rust-lang#33941. CC rust-lang#9082. r? `@oli-obk`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2022
Point at method chains on `E0271` errors Follow up to rust-lang#105332. Fix rust-lang#33941. CC rust-lang#9082. r? ``@oli-obk``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 15, 2022
Point at method chains on `E0271` errors Follow up to rust-lang#105332. Fix rust-lang#33941. CC rust-lang#9082. r? ```@oli-obk```
This was referenced Dec 15, 2022
|
☔ The latest upstream changes (presumably #105657) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
When `with_forced_trimmed_paths` is used, only print filename and start of the closure's span, to reduce their verbosity.
Do not say "Type changed to X here" when the only difference is caused by lifetimes.
estebank
force-pushed
the
iterator-chains
branch
from
7f8fdf4 to
2492235
Compare
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105481 (Start improving monomorphization items stats) - rust-lang#105674 (Point at method chains on `E0271` errors) - rust-lang#105679 (Suggest constraining type parameter with `Clone`) - rust-lang#105694 (Don't create dummy if val has escaping bounds var) - rust-lang#105727 (Tweak output for bare `dyn Trait` in arguments) - rust-lang#105739 (Migrate Jump to def links background to CSS variable) - rust-lang#105743 (`SimplifiedType` cleanups) - rust-lang#105758 (Move `TypeckResults` to separate module) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2024
…piler-errors,estebank Properly deal with GATs when looking for method chains to point at Fixes rust-lang#121898. ~~While it prevents an ICE and the structured suggestion is correct, the method chain diagnostic notes are weird / useless / incorrect judging by a quick look. I guess I should improve that in this PR.~~ Sufficiently taken care of. r? estebank or compiler-errors (rust-lang#105332, rust-lang#105674).
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 4, 2024
…ompiler-errors,estebank Properly deal with GATs when looking for method chains to point at Fixes rust-lang#121898. ~~While it prevents an ICE and the structured suggestion is correct, the method chain diagnostic notes are weird / useless / incorrect judging by a quick look. I guess I should improve that in this PR.~~ Sufficiently taken care of. r? estebank or compiler-errors (rust-lang#105332, rust-lang#105674).
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2024
Rollup merge of rust-lang#121912 - fmease:diag-method-chains-gat, r=compiler-errors,estebank Properly deal with GATs when looking for method chains to point at Fixes rust-lang#121898. ~~While it prevents an ICE and the structured suggestion is correct, the method chain diagnostic notes are weird / useless / incorrect judging by a quick look. I guess I should improve that in this PR.~~ Sufficiently taken care of. r? estebank or compiler-errors (rust-lang#105332, rust-lang#105674).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #105332. Fix #33941. CC #9082.
r? @oli-obk