-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative links in the unstable and rustc book #105763
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. |
You can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks! Happy to approve the PR once CI passes and you address the comments I left :)
r? @jyn514 |
Oh well, that was only 30 minutes and Ok, I'll do all your suggestions and fix the broken links, do you want me to squash and force-push? (I'm new to this) |
Yes, force-pushing would be great :) there are instructions on https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing |
Co-authored-by: Joshua Nelson <github@jyn.dev>
37b6a49
to
9ea3550
Compare
Looks great, thank you! @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (01ef4b2): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Fixes #98227.
As it stands, potential issues could arise from mismatch of stable/ nightly in the books. This PR fixes this issue by using relative links instead of absolute ones. I have replaced every absolute link under
src/doc/rustc
andsrc/doc/unstable-book/
and tested each manually.The link at
src/doc/rustc/src/targets/index.md:7
:[here](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_target/spec/struct.Target.html).
I need help with because my local directory structure and https://doc.rust-lang.org/ seem to be different, where is
nightly-rustc
?@jyn514