Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer to "Waker" rather than "RawWaker" in drop comment #105980

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Refer to "Waker" rather than "RawWaker" in drop comment #105980

merged 1 commit into from
Dec 22, 2022

Conversation

goffrie
Copy link
Contributor

@goffrie goffrie commented Dec 20, 2022

In my view this is technically more correct as Waker actually implements Drop (which calls the drop method) whereas RawWaker does not.

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 20, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@thomcc
Copy link
Member

thomcc commented Dec 21, 2022

Seems fine to me, but

r? @rust-lang/wg-async

@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2022

Failed to set assignee to taiki-e: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@thomcc
Copy link
Member

thomcc commented Dec 21, 2022

Uh, can someone from that group give this a sign-off then?

@thomcc
Copy link
Member

thomcc commented Dec 21, 2022

Thank you.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 21, 2022

📌 Commit f5e776c has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2022
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Dec 21, 2022
@fee1-dead
Rollup merge of rust-lang#105980 - goffrie:waker-drop, r=thomcc
200ddcb 
Refer to "Waker" rather than "RawWaker" in `drop` comment

In my view this is technically more correct as `Waker` actually implements `Drop` (which calls the `drop` method) whereas `RawWaker` does not.
@fee1-dead fee1-dead mentioned this pull request Dec 21, 2022
Closed
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Dec 21, 2022
@fee1-dead
Rollup merge of rust-lang#105980 - goffrie:waker-drop, r=thomcc
00419d5 
Refer to "Waker" rather than "RawWaker" in `drop` comment

In my view this is technically more correct as `Waker` actually implements `Drop` (which calls the `drop` method) whereas `RawWaker` does not.
@fee1-dead fee1-dead mentioned this pull request Dec 21, 2022
Closed
@JohnTitor JohnTitor mentioned this pull request Dec 21, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2022
@bors
Auto merge of rust-lang#106023 - JohnTitor:rollup-k8mettz, r=JohnTitor
8574880 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#105584 (add assert messages if chunks/windows are length 0)
 - rust-lang#105602 (interpret: add read_machine_[ui]size convenience methods)
 - rust-lang#105824 (str.lines() docstring: clarify that line endings are not returned)
 - rust-lang#105980 (Refer to "Waker" rather than "RawWaker" in `drop` comment)
 - rust-lang#105986 (Fix typo in reading_half_a_pointer.rs)
 - rust-lang#105995 (Add regression test for rust-lang#96530)
 - rust-lang#106008 (Sort lint_groups in no_lint_suggestion)
 - rust-lang#106014 (Add comment explaining what the scrape-examples-toggle.goml GUI test is about)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 03a763c into rust-lang:master Dec 22, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 22, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
Rollup merge of rust-lang#105980 - goffrie:waker-drop, r=thomcc
851c95f 
Refer to "Waker" rather than "RawWaker" in `drop` comment

In my view this is technically more correct as `Waker` actually implements `Drop` (which calls the `drop` method) whereas `RawWaker` does not.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#106023 - JohnTitor:rollup-k8mettz, r=JohnTitor
3981efa 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#105584 (add assert messages if chunks/windows are length 0)
 - rust-lang#105602 (interpret: add read_machine_[ui]size convenience methods)
 - rust-lang#105824 (str.lines() docstring: clarify that line endings are not returned)
 - rust-lang#105980 (Refer to "Waker" rather than "RawWaker" in `drop` comment)
 - rust-lang#105986 (Fix typo in reading_half_a_pointer.rs)
 - rust-lang#105995 (Add regression test for rust-lang#96530)
 - rust-lang#106008 (Sort lint_groups in no_lint_suggestion)
 - rust-lang#106014 (Add comment explaining what the scrape-examples-toggle.goml GUI test is about)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

@eholk eholk eholk approved these changes

Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@goffrie @rustbot @thomcc @bors @eholk @taiki-e