Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial stabilisation of c_unwind #106075

Merged
merged 3 commits into from
May 2, 2023
Merged

Partial stabilisation of c_unwind #106075

merged 3 commits into from
May 2, 2023

Conversation

nbdd0121
Copy link
Contributor

The stabilisation report is at #74990 (comment)

cc @rust-lang/wg-ffi-unwind

@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2022

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 23, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2022

These commits modify compiler targets.
(See the Target Tier Policy.)

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@aDotInTheVoid aDotInTheVoid removed the A-rustdoc-json Area: Rustdoc JSON backend label Dec 27, 2022
@nagisa
Copy link
Member

nagisa commented Jan 9, 2023

This is still waiting for the FCP to begin on the linked tracking issue. Relabeling as such.

@nagisa nagisa added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
@m-ou-se m-ou-se added the I-lang-nominated Nominated for discussion during a lang team meeting. label Feb 22, 2023
Copy link
Member

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes in the compiler seem correct to me.

@pnkfelix
Copy link
Member

pnkfelix commented Mar 7, 2023

This is still waiting for the FCP to begin on the linked tracking issue.

This is now waiting on @nikomatsakis to resolve their concern regarding the c-unwind docs. @nikomatsakis may choose to resolve their concern, in which case this will go into FCP, or they may choose to raise questions about those docs with the rest of T-lang team (as suggested by Eric Huss on Zulip)

@rustbot label: -I-lang-nominated

@rustbot rustbot removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Mar 7, 2023
@rustbot rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Apr 1, 2023
@nbdd0121
Copy link
Contributor Author

nbdd0121 commented Apr 1, 2023

FCP is now completed

@rustbot label: -S-waiting-on-team

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Apr 1, 2023
@nagisa
Copy link
Member

nagisa commented Apr 2, 2023

r=me, see comment, up to you if you think it is worth addressing.

@bors
Copy link
Contributor

bors commented Apr 3, 2023

☔ The latest upstream changes (presumably #109770) made this pull request unmergeable. Please resolve the merge conflicts.

@nbdd0121
Copy link
Contributor Author

@nagisa this is pending approval (I don't have review permission)

@joshtriplett
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Apr 28, 2023

📌 Commit 0ed8428137c52e3fbc9ae470dc5bd00985ee0957 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 28, 2023
@bors
Copy link
Contributor

bors commented Apr 29, 2023

☔ The latest upstream changes (presumably #110643) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2023
@nbdd0121
Copy link
Contributor Author

Rebased

@tmandry
Copy link
Member

tmandry commented May 1, 2023

@bors r=joshtriplett

@bors
Copy link
Contributor

bors commented May 1, 2023

📌 Commit c9a0be2 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2023
@bors
Copy link
Contributor

bors commented May 2, 2023

⌛ Testing commit c9a0be2 with merge 1cb6357...

@bors
Copy link
Contributor

bors commented May 2, 2023

☀️ Test successful - checks-actions
Approved by: joshtriplett
Pushing 1cb6357 to master...

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1cb6357): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% [-1.3%, -1.1%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.1% [1.3%, 5.2%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 655.389s -> 655.55s (0.02%)

@BatmanAoD
Copy link
Member

Thanks @tmandry and @joshtriplett !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend F-c_unwind `#![feature(c_unwind)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.