Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress errors due to TypeError not coercing with inference variables #106302

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Suppress errors due to TypeError not coercing with inference variables #106302

merged 1 commit into from
Dec 31, 2022

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Dec 30, 2022 •
edited
Loading

Fixes #75331
Fixes #68507
Fixes #82323

cc @estebank

@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 30, 2022
@estebank
Copy link
Contributor

If you still have this branch built, can you check if #102130, #88630, #100882 and #68507 are also fixed?

r? @estebank @bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2022

📌 Commit f6b45e3 has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned cjgillot Dec 30, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2022
Noratrieb added a commit to Noratrieb/rust that referenced this pull request Dec 31, 2022
@Noratrieb
Rollup merge of rust-lang#106302 - compiler-errors:terr-coerce-w-infe…
abeed83 
…r, r=estebank

Suppress errors due to TypeError not coercing with inference variables

Fixes rust-lang#75331
Fixes rust-lang#68507
Fixes rust-lang#82323

cc `@estebank`
@Noratrieb Noratrieb mentioned this pull request Dec 31, 2022
Closed
@bors
Copy link
Contributor

bors commented Dec 31, 2022

⌛ Testing commit f6b45e3 with merge 726bbfc...

@bors
Copy link
Contributor

bors commented Dec 31, 2022

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 726bbfc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2022
@bors bors merged commit 726bbfc into rust-lang:master Dec 31, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 31, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (726bbfc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@compiler-errors compiler-errors deleted the terr-coerce-w-infer branch August 11, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
6 participants
@compiler-errors @rustbot @estebank @bors @rust-timer @cjgillot