Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurate spans for arg removal suggestion #106347

Merged
merged 7 commits into from
Feb 16, 2023
Merged

More accurate spans for arg removal suggestion #106347

merged 7 commits into from
Feb 16, 2023

Commits on Feb 14, 2023

  1. More accurate spans for arg removal suggestion

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    f02d8ec View commit details
    Browse the repository at this point in the history

  2. Fix fmt

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    fb61f5d View commit details
    Browse the repository at this point in the history

  3. Avoid trailing commas

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    287cd59 View commit details
    Browse the repository at this point in the history

  4. rebase and review comments

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    5d63e10 View commit details
    Browse the repository at this point in the history

  5. Make removal suggestion not verbose

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    bd176ee View commit details
    Browse the repository at this point in the history

  6. Show the effects of weird code commented out

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    755252b View commit details
    Browse the repository at this point in the history

  7. Re-add replacement logic and add comment explaining it

    @estebank
    estebank committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    dff10d0 View commit details
    Browse the repository at this point in the history