Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust ast lowering doc tests #106486

Closed
wants to merge 5 commits into from
Closed

Rust ast lowering doc tests #106486

wants to merge 5 commits into from

Conversation

GentBinaku
Copy link

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2023
@GentBinaku
Copy link
Author

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned nagisa Jan 5, 2023
@apiraino
Copy link
Contributor

apiraino commented Jan 5, 2023 •
edited
Loading

work in progress for #99144

clubby789
clubby789 reviewed Jan 5, 2023
View reviewed changes
compiler/rustc_ast_lowering/src/lib.rs Outdated
/// ```
///
/// and return a type like `TestReturn<'static, T, 'a>`, so that the function looks like:
/// type TestReturn<'a, 'x, T> = impl Debug + 'x;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of deleting the codeblock, you can use rust,ignore at the header to prevent rustdoc from compiling or running it. You could also use text as the header to avoid treating it as a test at all, although you would lose syntax highlighting.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for being late on this PR; I didn't have the time.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2023
@GentBinaku GentBinaku requested a review from clubby789 January 14, 2023 11:33
@jyn514
Copy link
Member

jyn514 commented Jan 15, 2023

this has some overlap with #106574, unfortunately. cc @technetos, I haven't yet looked at the differences between the two.

@jyn514 jyn514 mentioned this pull request Jan 18, 2023
Merged
@jyn514
Copy link
Member

jyn514 commented Mar 11, 2023

Not sure when I'll have time to look at this.

r? @Nilstrieb

@rustbot ready

@rustbot rustbot assigned Noratrieb and unassigned jyn514 Mar 11, 2023
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2023
Noratrieb
Noratrieb reviewed Mar 11, 2023
View reviewed changes
compiler/rustc_ast_lowering/src/lib.rs
///
/// ```rust
/// fn test<'a, T: Debug>(x: &'a T) -> TestReturn<'static, T, 'a>
/// #![feature(type_alias_impl_trait)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also ignore this here?

@Noratrieb Noratrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2023
@bors
Copy link
Contributor

bors commented May 8, 2023

☔ The latest upstream changes (presumably #106621) made this pull request unmergeable. Please resolve the merge conflicts.

@Noratrieb
Copy link
Member

This was subsumed by #106486, closing it. Thank you for the PR anyways!

@Noratrieb Noratrieb closed this May 8, 2023
This was referenced May 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

@clubby789 clubby789 Awaiting requested review from clubby789

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GentBinaku @rustbot @apiraino @jyn514 @bors @Noratrieb @clubby789 @nagisa