Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add goml scripts to tidy checks #106602

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add goml scripts to tidy checks #106602

merged 2 commits into from
Jan 9, 2023

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 8, 2023
@notriddle
Copy link
Contributor

Seems reasonable to me, but I'd like to get this from someone who knows tidy as well.

r? bootstrap

@rustbot rustbot assigned Mark-Simulacrum and unassigned notriddle Jan 8, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

I'm not sure that 120 character limit on lines makes sense, but it seems OK. Ultimately it's an arbitrary number regardless.

@bors
Copy link
Contributor

bors commented Jan 9, 2023

📌 Commit 31b39be has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 9, 2023
@compiler-errors
Rollup merge of rust-lang#106602 - GuillaumeGomez:tidy-goml-scripts, …
5d11325 
…r=Mark-Simulacrum

Add goml scripts to tidy checks

r? `@notriddle`
This was referenced Jan 9, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2023
@bors
Auto merge of rust-lang#106616 - compiler-errors:rollup-emcj0o3, r=co…
2e677c0 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104163 (Don't derive Debug for `OnceWith` & `RepeatWith`)
 - rust-lang#106131 (Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible)
 - rust-lang#106363 (Structured suggestion for `&mut dyn Iterator` when possible)
 - rust-lang#106497 (Suggest using clone when we have &T and T implemented Clone)
 - rust-lang#106584 (Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator.)
 - rust-lang#106600 (Suppress type errors that come from private fields)
 - rust-lang#106602 (Add goml scripts to tidy checks)
 - rust-lang#106606 (Do not emit structured suggestion for turbofish with wrong span)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb6a88a into rust-lang:master Jan 9, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 9, 2023
@GuillaumeGomez GuillaumeGomez deleted the tidy-goml-scripts branch January 9, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @notriddle @rust-log-analyzer @Mark-Simulacrum @bors @rustbot