Warn when using panic-strategy abort for proc-macro crates #106678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
|
|
ehuss
reviewed
Jan 10, 2023
Veykril
force-pushed
the
proc-macro-panic-abort
branch
2 times, most recently
from
bdf9f11
to
05aa596
Compare
eholk
reviewed
Jan 11, 2023
|
Seems good to me. I made a tiny wording suggestion but feel free to r=me with or without the change. |
|
@bors r+ |
|
📌 Commit 05aa596f1aeab99549d234a2ae4273ee01bcade6 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
rustbot
added
the
S-waiting-on-author
|
@bors r- |
bors
removed
the
S-waiting-on-bors
Veykril
force-pushed
the
proc-macro-panic-abort
branch
from
05aa596
to
549ece7
Compare
|
@bors r=eholk |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 13, 2023
…eholk Warn when using panic-strategy abort for proc-macro crates See rust-lang#82320, this simply warns for now as that seems like the best step that can be immediately taken (opposed to straight up rejecting or ignoring)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 13, 2023
…eholk Warn when using panic-strategy abort for proc-macro crates See rust-lang#82320, this simply warns for now as that seems like the best step that can be immediately taken (opposed to straight up rejecting or ignoring)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104645 (Add log-backtrace option to show backtraces along with logging) - rust-lang#106465 (Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow) - rust-lang#106489 (Fix linker detection for linker (drivers) with a version postfix (e.g. clang-12 instead of clang)) - rust-lang#106585 (When suggesting writing a fully qualified path probe for appropriate types) - rust-lang#106641 (Provide help on closures capturing self causing borrow checker errors) - rust-lang#106678 (Warn when using panic-strategy abort for proc-macro crates) - rust-lang#106701 (Fix `mpsc::SyncSender` spinning behavior) - rust-lang#106793 (Normalize test output more thoroughly) - rust-lang#106797 (riscv: Fix ELF header flags) - rust-lang#106813 (Remove redundant session field) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #82320, this simply warns for now as that seems like the best step that can be immediately taken (opposed to straight up rejecting or ignoring)