Rollup of 13 pull requests #106833
Merged
Rollup of 13 pull requests #106833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continuation of work at rust-lang#98861
It's misleading. The main heading sometimes isn't an fully qualified name at all. It's also redundant. It's always a child of `div.main-heading`, so just use that.
…oggle This swaps things around so that the class that gets used more often has the shorter name.
…scottmcm reword Option::as_ref and Option::map examples The description for the examples of `Option::as_ref` and `Option::map` imply that the example is only doing type conversion, when it is actually finding the length of a string. Changes the wording to imply that some operation is being run on the value contained in the `Option` closes rust-lang#104476
…cottmcm Added error documentation for write_fmt This continuation of work at rust-lang#98861
…ook, r=GuillaumeGomez rustdoc: fix outdated lint section of the book
…, r=Mark-Simulacrum Check compiler docs in PR CI Fixes rust-lang#106624
…ap/mod.rs, r=Mark-Simulacrum mv binary_heap.rs binary_heap/mod.rs I confess this request is somewhat selfish, as it's made in order to ease synchronisation with my [copse](https://crates.io/crates/copse) crate (see eggyal/copse#6 for explanation). I wholly understand that such grounds may be insufficient to justify merging this request—but no harm in asking, right?
…r=GuillaumeGomez rustdoc: rename CSS rustdoc-toggle -> toggle and toggle -> settings-toggle This swaps things around so that the class that gets used more often has the shorter name.
…mulacrum Remove duplicate sha-1 dependency [`sha-1`](https://crates.io/crates/sha-1) is more or less a duplicate of [`sha1`](https://crates.io/crates/sha1). The `sha-1` is deprecated and no longer updated. This updates the dependencies to use the new name. Some other dependencies that got updated as a consequence: * The updated pest dependencies are currently only used by mdbook, and shouldn't have any issues. * ucd-trie 0.1.3 to 0.1.5: No changelog, but looks like some tables were updated for new unicode versions: https://github.com/BurntSushi/ucd-generate/commits/master/ucd-trie. This is only used by pest (and thus mdbook). * thiserror 1.33 to 1.38: Nothing significant in the notes at https://github.com/dtolnay/thiserror/releases.
… r=m-ou-se Add `AtomicPtr::as_mut_ptr` See rust-lang#66893 (comment) r? thomcc
…de, r=notriddle Remove dead code in rustdoc stripper No changes when this code is removed. cc `@aDotInTheVoid` r? `@notriddle`
…ulacrum Remove stale reference to the test suite location
…=cuviper Stop having unused lifetimes on some `impl`s See <https://doc.rust-lang.org/nightly/std/cmp/trait.PartialOrd.html#impl-PartialOrd%3COsStr%3E-for-PathBuf>, where these lifetimes show up even though they're not needed:  With this PR, the unneeded lifetimes are no longer there: 
Update `rental` hack to work with remapped paths. This PR simply switches to an already-existing helper instead of hard-coding a specific enum variant. The new revision of the test fails without the other changes in this PR. Context: I'm exploring running UI tests with remapped paths by default in rust-lang#105924 and the rental test was one of the ones that failed. This may also be useful in the context of rust-lang/rfcs#3127 ("New rustc and Cargo options to allow path sanitisation by default").
…uillaumeGomez rustdoc: remove unnecessary DOM class `h1.fqn` It's misleading. The main heading sometimes isn't an fully qualified name at all. It's also redundant. It's always a child of `div.main-heading`, so just use that.
rustbot
added
the
T-bootstrap
rustbot
added
A-testsuite
|
@bors r+ p=13 rollup=never |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: e9e0908367 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jan 14, 2023
Closed
|
Finished benchmarking commit (c0b8735): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
AtomicPtr::as_mut_ptr#106762 (AddAtomicPtr::as_mut_ptr)impls #106799 (Stop having unused lifetimes on someimpls)rentalhack to work with remapped paths. #106816 (Updaterentalhack to work with remapped paths.)h1.fqn#106819 (rustdoc: remove unnecessary DOM classh1.fqn)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup