Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused #![feature(box_syntax)] in alloc #106992

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Remove unused #![feature(box_syntax)] in alloc #106992

merged 1 commit into from
Jan 18, 2023

Conversation

joboet
Copy link
Member

@joboet joboet commented Jan 17, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@joboet joboet changed the title Remove unused #![feature(box_syntax] in alloc Remove unused #![feature(box_syntax)] in alloc Jan 17, 2023
@compiler-errors
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 18, 2023
@bors
Copy link
Contributor

bors commented Jan 18, 2023

⌛ Trying commit be9c363 with merge b52a002d5c42ba166151da1334befcaab2a039db...

@bors
Copy link
Contributor

bors commented Jan 18, 2023

☀️ Try build successful - checks-actions
Build commit: b52a002d5c42ba166151da1334befcaab2a039db (b52a002d5c42ba166151da1334befcaab2a039db)

1 similar comment
@bors
Copy link
Contributor

bors commented Jan 18, 2023

☀️ Try build successful - checks-actions
Build commit: b52a002d5c42ba166151da1334befcaab2a039db (b52a002d5c42ba166151da1334befcaab2a039db)

@rust-timer

This comment has been minimized.

Sign in to view
@est31
Copy link
Member

est31 commented Jan 18, 2023 •
edited
Loading

Hmmm interesting in #97293 I have removed it but it was reintroduced for some reason...

Edit: oh this PR is for the tests. I guess I forgot to remove the feature in #97494 . As for the perf run, it's overkill because the PR is a) in the tests, b) and only a #![feature(...)] is being removed, no change of the code itself. Such a PR wouldn't have an impact even if it changed the alloc crate.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b52a002d5c42ba166151da1334befcaab2a039db): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.0% [1.0%, 1.0%] 1

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 18, 2023
@thomcc
Copy link
Member

thomcc commented Jan 18, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 18, 2023

📌 Commit be9c363 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2023
@bors
Auto merge of rust-lang#107021 - matthiaskrgr:rollup-0dzxfyi, r=matth…
74c1ad5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106244 (Improve Markdown styling in README)
 - rust-lang#106747 (Add 'static lifetime suggestion when GAT implied 'static requirement from HRTB)
 - rust-lang#106873 (dont randomly use `_` to print out const generic arguments)
 - rust-lang#106992 (Remove unused `#![feature(box_syntax)]` in `alloc`)
 - rust-lang#106995 (bump failing assembly & codegen tests from LLVM 14 to LLVM 15)
 - rust-lang#106996 (rustdoc: instead of `.setting-name { width: 100% }`, use default div CSS)
 - rust-lang#106997 (Add heapsort fallback in `select_nth_unstable`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 47ccca0 into rust-lang:master Jan 18, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 18, 2023
@joboet joboet deleted the alloc_remove_box_syntax branch January 30, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
7 participants
@joboet @rustbot @compiler-errors @rust-timer @bors @est31 @thomcc