fixes the --set option in configure.py #107059
Conversation
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
|
r? @jyn514 |
This comment has been minimized.
This comment has been minimized.
|
I don't have time for reviews right now, sorry. |
|
This seems OK, but CI needs to be fixed before this can be merged. @rustbot author |
rustbot
added
S-waiting-on-author
|
I think its a whitespace issue, I will fix it right away |
|
Does this look okay @Mark-Simulacrum |
|
@shourya5 it can take a little while for reviews. If you haven't heard back in 10 days feel free to ping me or Mark. |
jyn514
added
S-waiting-on-review
|
You can use |
| o("manage-submodules", "build.submodules", | ||
| "let the build manage the git submodules") | ||
| o("full-bootstrap", "build.full-bootstrap", | ||
| "build three compilers instead of two (not recommended except for testing reproducible builds)") |
There was a problem hiding this comment.
Can we undo the re-formatting of this file?
| ./configure --set profile="user" | ||
| ./configure --set changelog-seen=2 |
There was a problem hiding this comment.
This isn't correct, it will overwrite config.toml. You need two --set flags in the same command I think. Please test the modified command to make sure it works.
Mark-Simulacrum
removed
the
S-waiting-on-review
Mark-Simulacrum
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #108464) made this pull request unmergeable. Please resolve the merge conflicts. |
closes issue #107049
This works by appending the CLI arguments to the end of the config.toml file. I am not sure this would work for all scenarios, but a good starting point regardless.