Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking change] Remove a rustdoc back compat warning #107291

Merged
merged 2 commits into from
Feb 26, 2023
Merged

[breaking change] Remove a rustdoc back compat warning #107291

merged 2 commits into from
Feb 26, 2023

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 25, 2023

This warning was introduced in #62855 for users who use rustdoc directly on proc macro crates (instead of using cargo doc) without passing --crate-type proc-macro (which cargo doc passed automatically).

@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@oli-obk oli-obk mentioned this pull request Jan 25, 2023
Closed
@jyn514
Copy link
Member

jyn514 commented Jan 25, 2023

cc rust-lang/cargo#7159 (comment)

@Aaron1011 are you still doing PR reviews?

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-proc-macros Area: Procedural macros labels Jan 25, 2023
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 25, 2023

@bors try

@bors
Copy link
Contributor

bors commented Jan 25, 2023

⌛ Trying commit 28aa96e835188a43a1a2638fadfa962cbedccd62 with merge 958246c3cfeb0a72f9a664bc7c584741fa1a805b...

@bors
Copy link
Contributor

bors commented Jan 25, 2023

☀️ Try build successful - checks-actions
Build commit: 958246c3cfeb0a72f9a664bc7c584741fa1a805b (958246c3cfeb0a72f9a664bc7c584741fa1a805b)

@Aaron1011
Copy link
Member

Could you add a test where we run rustdoc without passing --crate-type proc-macro?

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 4, 2023

@craterbot run mode=rustdoc

@craterbot
Copy link
Collaborator

👌 Experiment pr-107291 created and queued.
🤖 Automatically detected try build 958246c3cfeb0a72f9a664bc7c584741fa1a805b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-107291 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-107291 is completed!
📊 27 regressed and 7 fixed (254423 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 6, 2023
@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 6, 2023

There seems to be no code on crater that was ignoring this back compat warning

@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 9, 2023

r? @Aaron1011

@oli-obk oli-obk force-pushed the rustdoc_breaking_change branch from 28aa96e to 18d690f Compare February 9, 2023 15:11
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

@bors
Copy link
Contributor

bors commented Feb 22, 2023

☔ The latest upstream changes (presumably #103042) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

r=me after rebase

@oli-obk oli-obk force-pushed the rustdoc_breaking_change branch from 18d690f to ef2594c Compare February 22, 2023 19:41
@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 22, 2023

@bors r=estebank

@bors
Copy link
Contributor

bors commented Feb 22, 2023

📌 Commit ef2594cac4609ed89f1a602bfa643c1aae635ed6 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 22, 2023

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 22, 2023
@oli-obk oli-obk force-pushed the rustdoc_breaking_change branch from ef2594c to 60b0da1 Compare February 23, 2023 09:00
@oli-obk
Copy link
Contributor Author

oli-obk commented Feb 23, 2023

@bors r=estebank

@bors
Copy link
Contributor

bors commented Feb 23, 2023

📌 Commit 60b0da1 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2023
@compiler-errors compiler-errors mentioned this pull request Feb 25, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2023
@bors
Auto merge of rust-lang#108464 - compiler-errors:rollup-trl1g70, r=co…
f37f9f6 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105736 (Test that the compiler/library builds with validate-mir)
 - rust-lang#107291 ([breaking change] Remove a rustdoc back compat warning)
 - rust-lang#107675 (Implement -Zlink-directives=yes/no)
 - rust-lang#107848 (Split `x setup` sub-actions to CLI arguments)
 - rust-lang#107911 (Add check for invalid #[macro_export] arguments)
 - rust-lang#108229 ([107049] Recognise top level keys in config.toml.example)
 - rust-lang#108333 (Make object bound candidates sound in the new trait solver)

Failed merges:

 - rust-lang#108337 (hir-analysis: make a helpful note)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a4119ba into rust-lang:master Feb 26, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 26, 2023
@jyn514 jyn514 mentioned this pull request Feb 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aaron1011 Aaron1011

Labels
A-proc-macros Area: Procedural macros A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
9 participants
@oli-obk @rustbot @jyn514 @bors @Aaron1011 @craterbot @estebank @rust-log-analyzer @cjgillot