-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FromIterator
for (impl Default + Extend, impl Default + Extend)
#107462
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
This comment was marked as resolved.
This comment was marked as resolved.
As I mentioned in #85835 (comment), rayon has a parallel version of this here, but it's based on inner A nice benefit is that it composes well, like collecting |
r? libs-api Needs FCP. |
This looks a lot like |
We discussed this in the libs-api meeting today. We're happy to add this, but it should include a doc comment with an example. @rfcbot fcp merge |
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: Concerns:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
@the8472 somehow I've never seen Yes, this should be able to use |
It still composes better than |
Ah, right, makes sense. I'll clean up the PR once the FCP finishes. |
@Amanieu was it an accident that you removed FCP labels? It looks like you might have RMW-raced with rfcbot. |
Oops, I've added them back. |
@rfcbot concern doc-example I'm just registering this to make sure this impl gets some docs with an example before it's officially stabilized. |
…l Default+Extend<BE>)`
f804297
to
03862a5
Compare
@Amanieu @BurntSushi I've pushed a commit with documentation, does it look good? Does it resolve the concern? |
@rfcbot resolve doc-example |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f3c6608): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.553s -> 677.699s (0.02%) |
Similarly to how #85835 implemented
Extend
for(impl Extend, impl Extend)
: