Inline CSS background images directly into the CSS #107531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
force-pushed
the
inline-images-in-css
branch
from
14098e2
to
97a1cf6
Compare
notriddle
reviewed
Jan 31, 2023
GuillaumeGomez
force-pushed
the
inline-images-in-css
branch
from
97a1cf6
to
8e65783
Compare
|
Updated to keep the svg content as is instead of using base64 and added some backslashes. |
notriddle
requested changes
Jan 31, 2023
GuillaumeGomez
force-pushed
the
inline-images-in-css
branch
from
8e65783
to
63f82db
Compare
|
Updated! |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
notriddle
approved these changes
Feb 1, 2023
|
⌛ Testing commit 63f82db with merge 4a77303648d62e07be6ac2b2ba307cba229c6a34... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry CI was broken |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 2, 2023
…s, r=notriddle Inline CSS background images directly into the CSS A nice advantage of this is that it removes a few entries in the list of static files. r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 2, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#107201 (Remove confusing 'while checking' note from opaque future type mismatches) - rust-lang#107312 (Add Style Guide rules for let-else statements) - rust-lang#107488 (Fix syntax in `-Zunpretty-expanded` output for derived `PartialEq`.) - rust-lang#107531 (Inline CSS background images directly into the CSS) - rust-lang#107576 (Add proc-macro boilerplate to crt-static test) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice advantage of this is that it removes a few entries in the list of static files.
r? @notriddle