Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove arena_cache modifier from upstream_monomorphizations_for #107719

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Remove arena_cache modifier from upstream_monomorphizations_for #107719

merged 1 commit into from
Feb 8, 2023

Conversation

WaffleLapkin
Copy link
Member

Arena-caching a pointer is pretty meaningless as far as I can tell.

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 6, 2023
@WaffleLapkin
Copy link
Member Author

@bors try @rust-timer queue

Just in case

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 6, 2023
@bors
Copy link
Contributor

bors commented Feb 6, 2023

⌛ Trying commit 23412dd with merge 0e3bb0cfb38696ecb93d1ade2b8a5740a0961c7a...

@bors
Copy link
Contributor

bors commented Feb 6, 2023

☀️ Try build successful - checks-actions
Build commit: 0e3bb0cfb38696ecb93d1ade2b8a5740a0961c7a (0e3bb0cfb38696ecb93d1ade2b8a5740a0961c7a)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0e3bb0cfb38696ecb93d1ade2b8a5740a0961c7a): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.1% [1.1%, 1.1%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.8% [-0.8%, -0.7%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 6, 2023
@WaffleLapkin
Copy link
Member Author

I would assume it's noise, externs got a bit slower in incremental and a bit faster in non-incremental. in both cases the change happens in native_library, which doesn't seem to call the upstream_monomorphizations_for query.

@cjgillot
Copy link
Contributor

cjgillot commented Feb 7, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 7, 2023

📌 Commit 23412dd has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 7, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 7, 2023
@bors
Auto merge of rust-lang#107768 - matthiaskrgr:rollup-9u4cal4, r=matth…
3f059f6 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107719 (Remove `arena_cache` modifier from `upstream_monomorphizations_for`)
 - rust-lang#107740 (Avoid locking the global context across the `after_expansion` callback)
 - rust-lang#107746 (Split fn_ctxt/adjust_fulfillment_errors from fn_ctxt/checks)
 - rust-lang#107749 (allow quick-edit convenience)
 - rust-lang#107750 (make more readable)
 - rust-lang#107755 (remove binder from query constraints)
 - rust-lang#107756 (miri: fix ICE when running out of address space)
 - rust-lang#107764 (llvm-16: Use Triple.h from new header location.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 401fe5c into rust-lang:master Feb 8, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 8, 2023
@WaffleLapkin WaffleLapkin deleted the de-arena-allocates-you-UwU branch February 15, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@WaffleLapkin @rustbot @rust-timer @bors @cjgillot @TaKO8Ki