Update Clippy #108474
Merged
Update Clippy #108474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminals supporting the OSC8 Hyperlink Extension can support inline anchors where the text is user defineable but clicking on it opens a browser to a specified URLs, just like `<a href="URL">` does in HTML. https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com>
…, r=lcnr Implement `deferred_projection_equality` for erica solver Somewhat of a revival of rust-lang#96912. When relating projections now emit an `AliasEq` obligation instead of attempting to determine equality of projections that may not be as normalized as possible (i.e. because of lazy norm, or just containing inference variables that prevent us from resolving an impl). Only do this when the new solver is enabled
cast_possible_truncation: issue proper help message Fixes rust-lang#10325 --- changelog: Sugg: [`cast_possible_truncation`]: Corrected the lint name in help message [rust-lang#10330](rust-lang/rust-clippy#10330) <!-- changelog_checked-->
…=flip1995 lintcheck: fix clap panic clap 4.1.4 panics if `-` is used at the start of an argument: ``` $ cargo lintcheck […] thread 'main' panicked at 'Argument recursive: long "--recursive" must not start with a `-`, that will be handled by the parser', /home/sam/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-4.1.4/src/builder/debug_asserts.rs:82:13 ``` changelog: none <!-- changelog_checked -->
[arithmetic_side_effects] Fix rust-lang#10209 Fix rust-lang#10209 --- changelog: Enhancement: [`arithmetic_side_effects`]: No longer lints, if safe constant values are used. [rust-lang#10310](rust-lang/rust-clippy#10310) <!-- changelog_checked -->
… r=Manishearth Add `suspicious_command_arg_space` lint Fixes rust-lang#10316 --- changelog: New lint: [`suspicious_command_arg_space`] [rust-lang#10317](rust-lang/rust-clippy#10317) <!-- changelog_checked -->
Add new lint no_mangle_with_rust_abi Fixes issue rust-lang#10347 This PR adds a new lint `no_mangle_with_rust_abi` that suggests converting a function to the C ABI to if the function has the `#[no_mangle]` attribute and `Abi == Abi::Rust`. It will not run for any of the other variants defined in [rustc_target::spec::abi::Abi](https://doc.rust-lang.org/beta/nightly-rustc/rustc_target/spec/abi/enum.Abi.html), nor suggest any conversion other than conversion to the C ABI. Functions that explicitly opt into the Rust ABI with `extern "Rust"` are ignored by this lint. --- changelog: [`no_mangle_with_rust_abi`]: add lint that converts Rust ABI functions with the `#[no_mangle]` attribute to C ABI
…dnet Fix test function checker in `unwrap_used`, `expect_used` After rust-lang#9686 , `unwrap` and `expect` in integration tests and raw test functions won't be allowed. fixes rust-lang#10011 fixes rust-lang#10238 fixes rust-lang#10264 --- changelog: Fix: [`expect_used`], [`unwrap_used`], [`dbg_macro`], [`print_stdout`], [`print_stderr`]: No longer lint in test functions, if the related configuration is set [rust-lang#10391](rust-lang/rust-clippy#10391) <!-- changelog_checked -->
Do not panic when analyzing the malformed origin of a format string Fixes rust-lang#10148. This will trigger only when generating format strings while accepting weird things in a procedural macro and setting the span to something which is not a string. changelog: none
Rustup Looks like `@flip1995` is busy. r? `@ghost` changelog: None
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors r+ p=1 rollup=never |
|
📌 Commit 429913319b1540de72552bef1d216ba733b5ab50 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
I think this may need re-approval @Manishearth - merge process was interrupted due to force push. |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (d962ea5): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
|
Thanks for doing the update! I was planning to do it over the weekend, but then was on the road all weekend. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 10, 2023
Update Clippy Seems like `@flip1995` so this is a couple days late. r? `@Manishearth`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like @flip1995 so this is a couple days late.
r? @Manishearth