Rollup of 8 pull requests #108538
Merged
Rollup of 8 pull requests #108538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces build time of bootstrap by ~6s
…riplett Move IpAddr, SocketAddr and V4+V6 related types to `core` Implements RFC rust-lang/rfcs#2832. The RFC has completed FCP with disposition merge, but is not yet merged. Moves IP types to `core` as specified in the RFC. The full list of moved types is: `IpAddr`, `Ipv4Addr`, `Ipv6Addr`, `SocketAddr`, `SocketAddrV4`, `SocketAddrV6`, `Ipv6MulticastScope` and `AddrParseError`. Doing this move was one of the main driving arguments behind rust-lang#78802.
[stdio][windows] Use MBTWC and WCTMB `MultiByteToWideChar` and `WideCharToMultiByte` are extremely well optimized, and therefore should probably be used when we know we can (specifically in the Windows stdio stuff). Fixes rust-lang#107092
…lbertlarsan68 Allow building serde and serde_derive in parallel This reduces build time of bootstrap by ~6s
Move the unused extern crate check back to the resolver. It doesn't have anything to do in `rustc_hir_typeck`.
…acrum Bages for easy access links to Rust community r? `@Mark-Simulacrum`
…sts, r=jackh726 Commit some new solver tests Lazy norm is hard. `<?0 as Trait>::Assoc = ?0` ... probably should emit an alias-eq goal, but currently we don't do that. Right now it fails with a cyclical ty error. Also committed a check-pass test that broken when I attempted to fix this (unsuccessfully). r? types
…sions, r=Nilstrieb Avoid `&str` to `String` conversions This patch removes some unnecessary `&str` to `String` conversions.
…escr, r=compiler-errors diagnostics: avoid querying `associated_item` in the resolver Fixes rust-lang#108529 CC rust-lang#108324
rustbot
added
A-meta
|
@bors r+ rollup=never p=8 |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 7281249a19 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
📌 Perf builds for each rolled up PR: previous master: f540a25745 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 27, 2023
|
Finished benchmarking commit (7281249): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
This was referenced Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
core#104265 (Move IpAddr, SocketAddr and V4+V6 related types tocore)&strtoStringconversions #108523 (Avoid&strtoStringconversions)associated_itemin the resolver #108533 (diagnostics: avoid queryingassociated_itemin the resolver)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup