Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove issue number for link_cfg #108549

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

clubby789
Copy link
Contributor

@clubby789 clubby789 commented Feb 28, 2023

Fixes #72059

Per #37406 and its unstable book entry, this is an internal feature, and therefore perma-unstable and not being tracked

@rustbot
Copy link
Collaborator

rustbot commented Feb 28, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 28, 2023
@petrochenkov
Copy link
Contributor

this is an internal feature, and therefore perma-unstable

I wouldn't say that, but the stabilization is not planned in the near future at least, so we can merge this and make a new tracking issue once it's planned.

@JohnTitor
Copy link
Member

make a new tracking issue once it's planned.

Doesn't it make sense to open an issue now to discuss/make a plan?

@eholk
Copy link
Contributor

eholk commented Mar 23, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 23, 2023

📌 Commit e7c8af4 has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106964 (Clarify `Error::last_os_error` can be weird)
 - rust-lang#107718 (Add `-Z time-passes-format` to allow specifying a JSON output for `-Z time-passes`)
 - rust-lang#107880 (Lint ambiguous glob re-exports)
 - rust-lang#108549 (Remove issue number for `link_cfg`)
 - rust-lang#108588 (Fix the ffi_unwind_calls lint documentation)
 - rust-lang#109231 (Add `try_canonicalize` to `rustc_fs_util` and use it over `fs::canonicalize`)
 - rust-lang#109472 (Add parentheses properly for method calls)
 - rust-lang#109487 (Move useless_anynous_reexport lint into unused_imports)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a017d3 into rust-lang:master Mar 23, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link_cfg feature gate is associated to closed issue
6 participants